Contrib.social

Use !url placeholder in description string on System, Datetime, config_translation and views

Open on Drupal.org →
Created on 21 September 2021, over 3 years ago
Updated 12 August 2024, 4 months ago

Problem/Motivation

This is a followup to #2339021: Incorrect call to l() in system_token_info → to improve this string for translation.

'description' => t('A date in a custom format. See <a href="https://www.php.net/manual/datetime.format.php#refsect1-datetime.format-parameters">the PHP documentation</a> for details.'),

Steps to reproduce

Proposed resolution

Use !url placeholder substitution. See #2339021-11: Incorrect call to l() in system_token_info → and #2339021-12: Incorrect call to l() in system_token_info → for background.

Find all places having the URLs translatable. Replace with the token for the URL.

Remaining tasks

Patch
Review
Commit

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

🐛 Bug report
Status

Needs work

Version

11.0 🔥

Component
Token  →

Last updated 5 days ago

No maintainer
Created by

🇳🇿New Zealand quietone

Live updates comments and jobs are added and updated live.
  • Needs backport to D7

    After being applied to the 8.x branch, it should be considered for backport to the 7.x branch. Note: This tag should generally remain even after the backport has been written, approved, and committed.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Merge request !1341Issue #3238194: Use !url placeholder in description string in system_token_info → (Open) created by kunal.sachdev
  • Comment 5 months ago →
    🇳🇿New Zealand quietone
  • Assigned to arunkumark
  • Comment 4 months ago →
    🇮🇳India arunkumark Coimbatore
  • Status changed to Needs review 4 months ago
  • Comment 4 months ago →
    🇮🇳India arunkumark Coimbatore

    As per #11, the translatable strings for the links of custom date were verified and replaced.

    Also updated the Issue title and summary.

  • Issue was unassigned.
  • Comment 4 months ago →
    🇮🇳India arunkumark Coimbatore
  • Merge request !9153Use !url placeholder in description string [Drupal 11.x] → (Open) created by arunkumark
  • Comment 4 months ago →
    🇮🇳India arunkumark Coimbatore

    Created one more MR for the Drupal 11.x core.

  • Pipeline finished with Failed
    4 months ago
    Total: 1374s
    #249842
  • Status changed to Needs work 4 months ago
  • Comment 4 months ago →
    🇺🇸United States smustgrave

    Did not review but appears to have test failures.

  • Comment 4 months ago →
    🇮🇳India arunkumark Coimbatore

    arunkumark → changed the visibility of the branch 11.x to hidden.

  • Merge request !9176Date format URL translation → (Open) created by arunkumark
  • Pipeline finished with Canceled
    4 months ago
    Total: 128s
    #251326
  • Pipeline finished with Failed
    4 months ago
    Total: 462s
    #251328
  • Comment 4 months ago →
    🇮🇳India arunkumark Coimbatore

    arunkumark → changed the visibility of the branch 3238194-url-11 to hidden.

  • Merge request !9179Date format URL translation for D11 → (Open) created by arunkumark
  • Pipeline finished with Failed
    4 months ago
    Total: 942s
    #251528
  • Comment 4 months ago →
    🇮🇳India arunkumark Coimbatore

    @smustgrave

    Run PHPUnit multiple times locally. Got below errors, Hope the errors are random others not related to the changes that we made. If you're fine move to NR.

    1) Drupal\Tests\system\Functional\System\ErrorHandlerTest::testExceptionHandler
Behat\Mink\Exception\ResponseTextException: The text "SELECT "b".* FROM {bananas_are_awesome} "b"" was not found anywhere in the text of the current page.

/var/www/html/vendor/behat/mink/src/WebAssert.php:907
/var/www/html/vendor/behat/mink/src/WebAssert.php:293
/var/www/html/core/tests/Drupal/Tests/WebAssert.php:975
/var/www/html/core/modules/system/tests/src/Functional/System/ErrorHandlerTest.php:158

2) Drupal\Tests\system\Functional\System\HtaccessTest::testFileAccess
Response code to core/modules/system/tests/fixtures/HtaccessTest/access_test.engine should be 403
Failed asserting that 200 matches expected 403.

/var/www/html/core/modules/system/tests/src/Functional/System/HtaccessTest.php:153
/var/www/html/core/modules/system/tests/src/Functional/System/HtaccessTest.php:111

3) Drupal\Tests\system\Functional\System\HtaccessTest::testSvgzContentEncoding
Behat\Mink\Exception\ExpectationException: Current response header "x-encoded-content-encoding" is "", but "gzip" expected.

/var/www/html/vendor/behat/mink/src/WebAssert.php:888
/var/www/html/vendor/behat/mink/src/WebAssert.php:180
/var/www/html/core/tests/Drupal/Tests/WebAssert.php:963
/var/www/html/core/modules/system/tests/src/Functional/System/HtaccessTest.php:165

4) Drupal\Tests\system\Functional\UpdateSystem\UpdateScriptTest::testRequirements
Behat\Mink\Exception\ResponseTextException: The text "The Test Theme Depending on Modules theme has been installed" was not found anywhere in the text of the current page.

/var/www/html/vendor/behat/mink/src/WebAssert.php:907
/var/www/html/vendor/behat/mink/src/WebAssert.php:293
/var/www/html/core/tests/Drupal/Tests/WebAssert.php:975
/var/www/html/core/modules/system/tests/src/Functional/UpdateSystem/UpdateScriptTest.php:204
  • Comment 4 months ago →
    🇺🇸United States smustgrave

    If you re-ran the pipeline multiple times and they fail each time probably not random.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024