- Merge request !1341Issue #3238194: Use !url placeholder in description string in system_token_info → (Open) created by kunal.sachdev
- Assigned to arunkumark
- Status changed to Needs review
8 months ago 1:34pm 9 August 2024 - 🇮🇳India arunkumark Coimbatore
As per #11, the translatable strings for the links of custom date were verified and replaced.
Also updated the Issue title and summary.
- Issue was unassigned.
- Merge request !9153Use !url placeholder in description string [Drupal 11.x] → (Open) created by arunkumark
- Status changed to Needs work
8 months ago 7:02pm 11 August 2024 - 🇮🇳India arunkumark Coimbatore
arunkumark → changed the visibility of the branch 11.x to hidden.
- 🇮🇳India arunkumark Coimbatore
arunkumark → changed the visibility of the branch 3238194-url-11 to hidden.
- 🇮🇳India arunkumark Coimbatore
@smustgrave
Run PHPUnit multiple times locally. Got below errors, Hope the errors are random others not related to the changes that we made. If you're fine move to NR.
1) Drupal\Tests\system\Functional\System\ErrorHandlerTest::testExceptionHandler Behat\Mink\Exception\ResponseTextException: The text "SELECT "b".* FROM {bananas_are_awesome} "b"" was not found anywhere in the text of the current page. /var/www/html/vendor/behat/mink/src/WebAssert.php:907 /var/www/html/vendor/behat/mink/src/WebAssert.php:293 /var/www/html/core/tests/Drupal/Tests/WebAssert.php:975 /var/www/html/core/modules/system/tests/src/Functional/System/ErrorHandlerTest.php:158 2) Drupal\Tests\system\Functional\System\HtaccessTest::testFileAccess Response code to core/modules/system/tests/fixtures/HtaccessTest/access_test.engine should be 403 Failed asserting that 200 matches expected 403. /var/www/html/core/modules/system/tests/src/Functional/System/HtaccessTest.php:153 /var/www/html/core/modules/system/tests/src/Functional/System/HtaccessTest.php:111 3) Drupal\Tests\system\Functional\System\HtaccessTest::testSvgzContentEncoding Behat\Mink\Exception\ExpectationException: Current response header "x-encoded-content-encoding" is "", but "gzip" expected. /var/www/html/vendor/behat/mink/src/WebAssert.php:888 /var/www/html/vendor/behat/mink/src/WebAssert.php:180 /var/www/html/core/tests/Drupal/Tests/WebAssert.php:963 /var/www/html/core/modules/system/tests/src/Functional/System/HtaccessTest.php:165 4) Drupal\Tests\system\Functional\UpdateSystem\UpdateScriptTest::testRequirements Behat\Mink\Exception\ResponseTextException: The text "The Test Theme Depending on Modules theme has been installed" was not found anywhere in the text of the current page. /var/www/html/vendor/behat/mink/src/WebAssert.php:907 /var/www/html/vendor/behat/mink/src/WebAssert.php:293 /var/www/html/core/tests/Drupal/Tests/WebAssert.php:975 /var/www/html/core/modules/system/tests/src/Functional/UpdateSystem/UpdateScriptTest.php:204
- 🇺🇸United States smustgrave
If you re-ran the pipeline multiple times and they fail each time probably not random.
- 🇸🇰Slovakia poker10
The last pipeline (https://git.drupalcode.org/issue/drupal-3238194/-/pipelines/251544) has multiple failures of:
Placeholders must begin with one of the following "@", ":" or "%", invalid placeholder (!url) with string: "A user-defined date format. See the PHP manual for available options." Drupal\Component\Render\FormattableMarkup::placeholderFormat() Line: 235)
Is the issue summary up to date? Because the proposed resolution refers to #2339021-11: Incorrect call to l() in system_token_info → , which is a comment year before the
!url
placeholder was removed in #2571695: Remove !placeholder and unsafe string return from SafeMarkup::format() → .