/Drupal calls and t() calls should be avoided in classes.

$ phpcs --standard=DrupalPractice . FILE: /focal_point/src/Controller/FocalPointPreviewController.php ----------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ----------------------------------------------------------------------------------------------------------------- 265 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 266 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead ----------------------------------------------------------------------------------------------------------------- FILE: /focal_point/src/Plugin/Field/FieldWidget/FocalPointImageWidget.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------------- 51 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ----------------------------------------------------------------------------------------------------------------------------------------- FILE: /focal_point/tests/src/Functional/FocalPointWidgetTest.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------------- 84 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead -----------------------------------------------------------------------------------------------------------------------------------------

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 7 months ago →
🇮🇳India dev16.addweb
silvi.addweb → made their first commit to this issue’s fork.
Status changed to Needs work 7 months ago6:43am 30 April 2024
Comment 7 months ago →
🇮🇳India dev16.addweb
@ankithashetty, Thanks, your patch looks good. However, we also need to fix some use statement sequences to adhere to coding standards.
Merge request !26Fixed Php coding standards. → (Open) created by Unnamed author
Status changed to Needs review 7 months ago6:50am 30 April 2024
Comment 7 months ago →
🇮🇳India dev16.addweb
Comment 7 months ago →
🇮🇳India aman1248
Amandeep123 → made their first commit to this issue’s fork.
Status changed to RTBC 7 months ago8:03am 7 May 2024
Comment 7 months ago →
🇮🇳India aman1248
Hi @Rajeshreeputra,

I've thoroughly tested merge request !26 and confirmed that it's working perfectly. I've addressed all the errors related to /Drupal calls and deprecated t() calls in classes. working properly.
thanks.
First commit to issue fork.
Merge request !29Issue #3228017 by Rajeshreeputra, silvi.addweb, ankithashetty, Amandeep123:... → (Merged) created by rajeshreeputra
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.2 & MySQL 8
last update 7 months ago
159 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.2 & MySQL 8
last update 7 months ago
159 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.2 & MySQL 8
last update 7 months ago
159 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.2 & MySQL 8
last update 7 months ago
159 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.2 & MySQL 8
last update 7 months ago
159 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.2 & MySQL 8
last update 7 months ago
159 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.2 & MySQL 8
last update 7 months ago
158 pass, 2 fail
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.2 & MySQL 8
last update 7 months ago
159 pass
Pipeline finished with Skipped
7 months ago
#166317
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.2 & MySQL 8
last update 7 months ago
159 pass
Comment 7 months ago →
System Message

Rajeshreeputra → committed fcc71121 on 2.x
Issue #3228017 by Rajeshreeputra: /Drupal calls and t() calls should be...
Comment 7 months ago →
🇮🇳India rajeshreeputra Pune
Merged MR for 2.x branch, Thanks!
Comment 7 months ago →
🇺🇸United States DamienMcKenna NH, USA
This one was accidentally reopened by the commit bot.
Status changed to Fixed 5 months ago5:50am 19 June 2024
Comment 5 months ago →
🇮🇳India rajeshreeputra Pune
Comment 5 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

/Drupal calls and t() calls should be avoided in classes.

Problem/Motivation

Proposed resolution

User interface changes

API changes

Data model changes

Merge Requests

!29/Drupal calls and t() calls should be avoided in classes.
Merged

!26/Drupal calls and t() calls should be avoided in classes.
Open

Comments & Activities

/Drupal calls and t() calls should be avoided in classes.

Problem/Motivation

Proposed resolution

User interface changes

API changes

Data model changes

Merge Requests

!29/Drupal calls and t() calls should be avoided in classes.Merged

!26/Drupal calls and t() calls should be avoided in classes.Open

Comments & Activities

!29/Drupal calls and t() calls should be avoided in classes.
Merged

!26/Drupal calls and t() calls should be avoided in classes.
Open