Problem/Motivation
The 'Welcome (no approval required)' e-mail is sent to newly registered users when no administrator approval is required.
The same e-mail is sent regardless of whether e-mail verification is required or not, however it only makes sense when e-mail verification is required.
[user:display-name],
Thank you for registering at [site:name]. You may now log in by clicking this link or copying and pasting it into your browser:
[user:one-time-login-url]
This link can only be used once to log in and will lead you to a page where you can set your password.
After setting your password, you will be able to log in at [site:login-url] in the future using:
username: [user:name]
password: Your password
-- [site:name] team
If you're already logged in and click the password reset link, it doesn't take you anywhere useful.
Additionally, while AccountSettingsForm
adds a checkbox to enable/disable notifications for some e-mails (and all have this option in user.settings.yml), it doesn't do so for the registration e-mail.
This was reported to me and amateescu via a client site, I am pretty convinced everyone who uses Drupal regularly never reads this e-mail let alone tries to click the link.
Steps to reproduce
Proposed resolution
There are a couple of options here:
1. Add a new e-mail template and associated config, which has a welcome e-mail for the case where e-mail validation isn't required. This will need completely different text from the current one.
and/or
2. Add the 'Notify user when [blah]' checkbox to the form so that the e-mail can be enabled disabled - this could probably be done for all of the e-mails for consistency.
3. Just don't send an e-mail at all from the registration form when user's can choose their own passwords (one line patch but probably not optimal).
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet