- Merge request !3043Resolve #3224276 "10.1 move entity helpers to kerneltestbase" → (Open) created by joachim
- 🇬🇧United Kingdom joachim
joachim → changed the visibility of the branch 3224276-move-entity-helpers-to-KernelTestBase to hidden.
- 🇬🇧United Kingdom joachim
joachim → changed the visibility of the branch 3224276-10.1-move-entity-helpers-to-KernelTestBase to hidden.
- 🇬🇧United Kingdom joachim
Resolved all points from @xjm in a new branch 3224276-11-move-entity-helpers-to-KernelTestBase off 11.x.
I'm coming round to the idea of a trait -- it means it can be used in functional tests too.
Making a new branch for that approach.
Also, once this is in, we can add #3267404: Add a PHPUnit assertion that an entity is valid → to this new trait too.
- Merge request !8721Resolve #3224276 "11 move entity helpers to test trait" → (Open) created by joachim
- Status changed to Needs review
5 months ago 2:34pm 9 July 2024 - Status changed to RTBC
4 months ago 3:10pm 22 July 2024 - 🇺🇸United States smustgrave
Checked the threads from the old MR 3043 and they all seemed to have made it into the 11.x MR 8721
Moving these to a trait seems like a good idea. Not sure if it will need a CR though for contrib to use the new trait? But won't hold on that.
- 🇳🇿New Zealand quietone
I read the IS, comments and the MR. I found that all questions have been answered and I have no recommendations. Leaving at RTBC.
- Status changed to Fixed
3 months ago 8:16pm 20 August 2024 - 🇫🇷France nod_ Lille
Committed and pushed adb813c5de to 11.x and 2975de0ee7 to 10.4.x. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.