Drupal 9/10 compatible release and plan?

@johnzzon if you're still interested, this might also be interesting for you: ✨ Split experimental access modes into submodules Active

Hope @marcoscano replies soon, so we can procceed here after 📌 Offering to (Co-)Maintain Media Private Access Postponed

@marcoscano: Just took some time to check the module for Drupal 10 compatibility and update the MR. Upgrade status says "No problems detected", so I think it shouldn't do any harm to merge this into dev to be able to work on the project in a Drupal 9 / 10 environment?

Could you have a look and merge this, if it's fine for you to unlock the next steps?
Perhaps it makes sense to put this into a 2.x semver branch and deprecate the 8.x-1.x-dev branch?

Thanks! :)

The module is installable, but after setting all media types to "Permission Based", the following Error appears:

ArgumentCountError: Too few arguments to function Drupal\media\MediaAccessControlHandler::__construct(), 1 passed in /var/www/html/web/modules/custom/media_private_access-3222522/src/MediaPrivateAccessControlHandler.php on line 74 and exactly 2 expected in Drupal\media\MediaAccessControlHandler->__construct() (line 34 of core/modules/media/src/MediaAccessControlHandler.php).

Using Drupal 10.0, PHP 8.1, 10.3.37-MariaDB

Fixed, the problem was, that the parent class already defines an entity type manager, and its constructor needed it as a parameter.

Please review!

Nice finding @Grevil, thanks! As upgrade status is happy and I can't find any other issues, let's set this RTBC to proceed with the other issues! :)

I'm not being able to run the tests against the PR, maybe it needs to be in first. I'm going to merge, and then we can address possible test failures as follow-up in this same issue.

Yep, so the tests in 10.x failed: https://www.drupal.org/pift-ci-job/2646940 →

Let's work on fixing them here, targeting the now open 2.x branch

@marcoscano, testing inside Drupal issue's should be fixed now! There was a problem with Gitlab, which lead to Jenkins using a faulty url to pull and test the url, but @drumm hot fixed it yesterday, so it should be working again! See https://gitlab.com/gitlab-org/gitlab/-/issues/404496#note_1357660691.

Nonetheless, I should've run the tests locally before setting this issue RTBC. My apologies.

Going to fix this ASAP.

OK, there are actually quite a few deprecation problems with the tests, as they do not meet the Drupal 9/10 Test standards. I created a separate issue, to not overload this issue.

See 📌 Adjust old tests Fixed .

FYI, it seems, that you accidentally pushed the "3222522-drupal-9-compatible" to the main repository! Just a heads up :)

>FYI, it seems, that you accidentally pushed the "3222522-drupal-9-compatible" to the main repository! Just a heads up :)

True, fixed now. Thanks!

@marcoscano: Grevil just fixed the tests in 📌 Adjust old tests Fixed thanks for that! :)

@marcoscano sorry but could you perhaps have a look at that RTBC'd fix issue?

Our offer for co-maintainership still stands.

Merged, thanks for the work and for the patience! :)

Shouldn't the status here also be "Fixed" then? Or what am I missing?

Automatically closed - issue fixed for 2 weeks with no activity.