Created on 19 April 2023, about 1 year ago
Updated 23 August 2023, 10 months ago

Problem/Motivation

The current tests are old and should be adjusted to the new Drupal 9/10 Test standards.

Steps to reproduce

Proposed resolution

Adjust the tests accordingly.

Remaining tasks

User interface changes

API changes

Data model changes

πŸ“Œ Task
Status

Fixed

Version

2.0

Component

Code

Created by

πŸ‡©πŸ‡ͺGermany Grevil

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Grevil
  • Open in Jenkins β†’ Open on Drupal.org β†’
    Core: 10.1.x + Environment: PHP 8.2 & MySQL 8
    last update about 1 year ago
    3 pass
  • @grevil opened merge request.
  • Status changed to Needs review about 1 year ago
  • πŸ‡©πŸ‡ͺGermany Grevil

    Alright! The tests should be fixed now.

    I almost went insane trying to figure out, why the "media/{id}" route didn't resolve even with the "standalone_url" setting enabled. Turns out, the routing needs to get rebuild after changing that setting inside tests.

    Furthermore, I needed to adjust your "media->label() present" check, as on default the label won't get displayed and I didn't want to tinker with the media view_mode settings.

    Please review!

  • Status changed to RTBC about 1 year ago
  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

    Nice work @Grevil! Tests pass again and changes make sense.

    Switching to Olivero is untypical and makes the tests slower and more memory-consuming. Are there any good alternatives in using a more lightweight theme which also allows selectors?

    Still I'll set this RTBC for the maintainer to decide, how to proceed. We could also keep it this way or change the theme later in a follow-up.

  • First commit to issue fork.
  • Status changed to Fixed 10 months ago
  • πŸ‡ͺπŸ‡ΈSpain marcoscano Barcelona, Spain

    Good work, thanks! And sorry for the delayed review.

  • πŸ‡©πŸ‡ͺGermany Grevil

    Thanks! No worries, great, that they are in now! 😁

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024