- Issue created by @Grevil
- last update
over 1 year ago 3 pass - @grevil opened merge request.
- Status changed to Needs review
over 1 year ago 10:06am 19 April 2023 - 🇩🇪Germany Grevil
Alright! The tests should be fixed now.
I almost went insane trying to figure out, why the "media/{id}" route didn't resolve even with the "standalone_url" setting enabled. Turns out, the routing needs to get rebuild after changing that setting inside tests.
Furthermore, I needed to adjust your "media->label() present" check, as on default the label won't get displayed and I didn't want to tinker with the media view_mode settings.
Please review!
- Status changed to RTBC
over 1 year ago 10:18am 19 April 2023 - 🇩🇪Germany Anybody Porta Westfalica
Nice work @Grevil! Tests pass again and changes make sense.
Switching to Olivero is untypical and makes the tests slower and more memory-consuming. Are there any good alternatives in using a more lightweight theme which also allows selectors?
Still I'll set this RTBC for the maintainer to decide, how to proceed. We could also keep it this way or change the theme later in a follow-up.
- First commit to issue fork.
-
marcoscano →
committed 00d9d0cc on 2.x authored by
Grevil →
Issue #3355053 by Grevil, Anybody: Adjust old tests
-
marcoscano →
committed 00d9d0cc on 2.x authored by
Grevil →
- Status changed to Fixed
over 1 year ago 1:10pm 22 August 2023 - 🇪🇸Spain marcoscano Barcelona, Spain
Good work, thanks! And sorry for the delayed review.
Automatically closed - issue fixed for 2 weeks with no activity.