- Merge request !38Issue #3220689: Link to set a theme as default for a domain is missing domain_config_ui_domain querystring → (Open) created by igor mashevskyi
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 11:36am 7 April 2023 - Status changed to Needs work
over 1 year ago 6:37pm 27 April 2023 - last update
over 1 year ago 93 pass, 1 fail - last update
over 1 year ago 93 pass, 1 fail - last update
over 1 year ago 93 pass, 2 fail - last update
over 1 year ago 93 pass, 2 fail - last update
over 1 year ago 93 pass, 2 fail - last update
over 1 year ago 94 pass - Status changed to Needs review
over 1 year ago 12:40pm 29 June 2023 Hi guys, any updates here?
Can somebody check my changes?
Thank you in advance- last update
9 months ago Composer error. Unable to continue. - last update
9 months ago run-tests.sh fatal error - 🇺🇸United States agentrickard Georgia (US)
Patch looks good and there is a test! Re-queuing the test bot.
It's a shame there is no way to alter the theme operations except through the page preprocess, but that's a core issue.
- 🇺🇸United States agentrickard Georgia (US)
This needs to be against the 2.0 branch.
- last update
9 months ago run-tests.sh fatal error - Status changed to Needs work
9 months ago 3:44pm 29 March 2024 - 🇺🇸United States agentrickard Georgia (US)
@Igor Mashevskyi The MR will need to be redone against 2.0.x.
- Merge request !74Issue #3220689 by Igor Mashevskyi: Link to set a theme as default for a domain... → (Open) created by igor mashevskyi
- Status changed to Needs review
8 months ago 7:59am 29 April 2024 - Status changed to Needs work
7 months ago 7:04pm 28 May 2024 - 🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin
Despite of all the appreciated hard work in here I - sorry- cannot reproduce the issue.
Summary states:
If I click the Set as default link the theme is incorrectly set as default for all domains instead of just for the example domain.
This is not correct, at least not for latest dev and latest beta. It is correct that it "feels as if it would be set for all domains" because the selected domain jumps out of the select box by the page refresh on save, which is caused by another (not yet reported) issue: "select box does not keep selected domain after page refresh". But the setting is correctly made for the previously selected domain. At least on our tests here. You can circumvent this behaviour by selecting "remember last selection" in domain form settings.
So we maybe need to further investigate here before rerolling and committing to "not fix something which is not broken". Would recommend to collect more reports on this.
- Status changed to Needs review
about 2 months ago 10:53am 11 November 2024 @dqd thanks for the comment
I've rechecked this issue and I still have it ("If we select the specific domain and click the Set as default link the theme is incorrectly set as default for all domains instead of just for the example domain")
But after applying the patch it works correctlyCould you please take a look at this issue one more time when you have time?