Space next to email in link text causes empty link text

For now here is a reroll of #12 on 3.x.

Ok I need to revert back to 1.x for other unrelated reasons, here is a reroll for 1.x if needed.

many thanks @herved! The javascript code was already in debt, breaking a few coding standards, but after the patch there are even more complaints. Would you have capacity to fix them?

See here: https://www.drupal.org/pift-ci-job/2633797 →

Ok I'm not sure why my prettier output is different than the one from CI...
I use the config from drupal core (/core/.eslintrc.json) though.
Let's try this.

Thank you for the fixes and tests here. @Grevil could you check this?

Switching to an issue fork workflow, for easier reviewability and general ease of use.

The js part LGTM, the php part needs some further refactoring. I generally feel like "filterTagContents" just simply filters way too much. I understand filtering the content for XSS stuff, but for this to work properly, we should adjust the method. "output()" shouldn't have this weird filter behavior based on whether the email is part of the content or not. "filterTagContents" should simply leave the mail in. Although I understand the conflict from #305464: Something broken? → , but we need further work on this.

Thanks for your investigations and work on this @Grevil!

I think we should first implement tests in
📌 Test & ensure attributes and complex HTML within the mailto link doesn't break Fixed
📌 Write basic install / uninstall tests Fixed
and ensure 🐛 Test input filtering to be idempotent Fixed works as expected, as they're far more important and prove the module works as expected by tests in large parts.
Setting this postponed for now, until these are solved.

I'd really like this to be in, before we touch the JavaScript code anywhere else. I'll only postpone this on 📌 Write basic install / uninstall tests Fixed and 📌 Write functional javascript tests for the base functionality and some major issues Fixed . And afterward, we'll take a look at this again.

Alright, 📌 Write functional javascript tests for the base functionality and some major issues Fixed is fixed! Let's rebase this fork and see, if it breaks any existing functionality or even fixes some of it!

Damn, I messed up... pressed the rebase button one too many times and now it is merged.

Ok nice, reverted!

Tests are failing.

@Grevil: Are you planning to finish this? Or how do we proceed here?

No, not really, probably wasn't the best issue to start with here...

But if anyone else would like to take a go, feel free to! (Although the code needs quite the rebase).

Created a new MR for anyone, wanting to tackle this issue. Unfortunately, I can not close "MR !7", as I accidentally merged it earlier.

Ok let's finally make this major, as it's one of the two last important bugs known here... A space shouldn't break spamspan.