Write functional javascript tests for the base functionality and some major issues

Closing this as duplicate of 📌 Test & ensure attributes and complex HTML within the mailto link doesn't break Fixed which allows fixes, if the tests fail and already provides details.

I'd like to only write tests inside this issue, no code adjustments.

Ok, I finished the tests for 📌 Test & ensure attributes and complex HTML within the mailto link doesn't break Fixed . Turns out the module isn't compatible with any complex mailto structures.

Thanks @Grevil. Yes, we should separate these mailto: parameter tests and comment them out with a link to this feature request to be implemented: ✨ Allow for further mailto: link parameters like subject, cc, ... Active

This is nothing important for the base functionality of SpamSpan and very rarely used.

The important part are the complex HTML structure tests from 📌 Test & ensure attributes and complex HTML within the mailto link doesn't break Fixed . That needs to work fine :)

@Grevil: RTBC from my side. Merge as soon as you need it.

tests/src/FunctionalJavascript/SpamSpanComplexHrefTest.php should better be named tests/src/FunctionalJavascript/SpamSpanComplexHrefMailtoTest.php as that's more clearly what it does :)

Alright, we should have all basic test cases covered now. I disabled the complex href tests for now, as well as the "testMailUnobscuringWithMailAndStringInText" test, since that is not working yet (we can enable this in the appropriate issue).

Please review!

Alright, all tests are green! Let's commit this, as it has already been RTBC'd aswell! :)

Nice! We need to test the module without JS as well to make sure that the obfuscated markup - before it's normalized by JS - is correct and still readable. The spampsan twig extension is not tested either, but I already made a unit test for it in #3372768 🐛 Twig extension strips anchor tags from the processed text Fixed .

@joevagyok I think there already were unit tests before in the module. So that's existing. See https://git.drupalcode.org/project/spamspan/-/blob/3.x/tests/src/Kernel/...

Thank you for your additional tests. We'll look into the issues and comment there :)

Automatically closed - issue fixed for 2 weeks with no activity.