- Issue created by @Anybody
- 🇩🇪Germany Grevil
Ok, the encoding logic itself is not "idempotent", BUT it doesn't actually need to be, as the encoding SHOULD only run once:
if (strpos($href, 'mailto:') === 0) { $atag->setAttribute('href', $href); $text = $this->replaceMailtoLinks($document->saveHTML($atag), $altered); $this->replaceDomNode($atag, $text); }
We only encode, if there is a "mailto" at the start of a href, otherwise strpos returns false, and we won't jump inside the if case. I'll do some further investigation.
- 🇩🇪Germany Anybody Porta Westfalica
Re #4 please see the other issues, before working on fixes yourself. Like 🐛 Fix Email address being removed in the link text and fix every second link not being obfuscated Fixed .
But first let's have tests for idempotency!
- last update
over 1 year ago 14 pass, 1 fail - @grevil opened merge request.
- last update
over 1 year ago 15 pass - Status changed to Needs review
over 1 year ago 10:39am 12 July 2023 - last update
over 1 year ago 15 pass - Status changed to RTBC
over 1 year ago 11:51am 12 July 2023 - 🇩🇪Germany Anybody Porta Westfalica
RTBC! Super nice work! Just 1 comment for the comment ;)
- last update
over 1 year ago 16 pass - last update
over 1 year ago 16 pass - last update
over 1 year ago 16 pass - Status changed to Fixed
over 1 year ago 12:58pm 12 July 2023 Automatically closed - issue fixed for 2 weeks with no activity.