The Needs Review Queue Bot โ tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
- Status changed to Needs review
almost 2 years ago 12:33am 31 January 2023 - ๐ฎ๐ณIndia nayana_mvr
Do we need to change the description as mentioned in the original problem statement. Because while testing in Drupal version 10.1.x, I could see 2 different options now. I think it was implemented as mentioned in #15 ๐ Clarify/Improve "Track images" text filter option title/description Needs work
1. Track images uploaded via a Text Editor.
2. Lazy load imagesIf we apply the latest MR changes, it will look like this
There is already a separate option for lazy loading with description that says that this option should be placed after the option 'Track images uploaded via a Text Editor'.
Please correct me if I'm wrong.
- Status changed to Needs work
almost 2 years ago 10:54pm 13 March 2023 - ๐ฉ๐ชGermany rkoller Nรผrnberg, Germany
@smustgrave forwarded the issue to the #ux channel. i've taken a look at the current state. there are a few things i've noticed.
1. the patch changes the checkbox label from
Track images uploaded via a Text Editor
toEnsure latest image revision are referenced and append lazy=loading
. problem is the description for the next checkbox labellazy load images
references the previous checkbox labelInstruct browsers to lazy load images if dimensions are specified. Use in conjunction with and place after the 'Track images uploaded via a Text Editor' filter that adds image dimensions required for lazy loading. Results can be overridden by <img loading="eager">.
which still uses the old wording and would have to be updated as well.2. but the bigger problem is what the actual function of that checkbox
Ensure latest image revision are referenced and append lazy=loading
is. i can second the question in comment#13
. i don't quite understand what the filter actually does with the original label nor with the current. my train of thought reading the current label and description:- when i scan the checkbox label at first the term
image
strikes my eye - based on that i would have assumed the functionality applies in case i try to add an image in a ckeditor5 wysiwyg field. - but then there are the words "latest" and "revision" which sounds more like it is about media entities?!
- and then
lazy=loading
is also applied - but i ask myself the question why is there another checkbox about lazy loading, wasn't lazy loading already added to the markup in the previous step? - and i ask myself to what that latest image revision is referenced to at all? does reference mean the image dimensions are getting set?
so based on the micro copy the purpose of each checkbox isn't clearly evident. the apparent functional interdependence and overlap of the two filters complicates things further. i'll set the issue back to needs work.
- when i scan the checkbox label at first the term