Contrib.social

When adding a node translation pick the menu item in the language from the source

Open on Drupal.org →
Created on 31 March 2021, over 3 years ago
Updated 3 February 2023, over 1 year ago

Problem/Motivation

When adding a translation of a node, the first menu item translation is used, instead of the menu item in the (selected) source language.

Steps to reproduce

Have at least 4 languages enabled.
Add a node with a menu item.
Translate that node and menu item into the 2 other languages.
Go to the form to add translation of the fourth language.
When selecting a different Source Language, the menu item does not change.

Proposed resolution

For new translations, use ContentTranslationManager to grab the translation metadata to find the correct language to retrieve the menu item translation from.

Remaining tasks

Make patch.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

-

✨ Feature request
Status

Needs work

Version

10.1 ✨

Component
Menu UI  →

Last updated 17 days ago

No maintainer
Created by

🇳🇱Netherlands spadxiii

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 1 year ago →
    🇺🇸United States smustgrave

    This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

    MR will need to be updated for 10.1
    Also will require tests to be added to it

    Did not test for issue FYI

    Thanks!

  • First commit to issue fork.
  • @ankithashetty opened merge request.
  • Comment over 1 year ago →
    🇮🇳India ankithashetty Karnataka, India

    Raised a new MR !3374 against 10.1.x as requested.
    Retaining the status as 'Needs work' as it still requires tests.

    Thanks!

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024