Use separate attribute for big pipe replacement callback info

Created on 8 February 2021, over 3 years ago
Updated 17 March 2023, over 1 year ago

Motivation

The big pipe placeholder IDs sent to the client contain information on the callback that is used server-side to build the replacement. This is only meant for debugging purposes.

This issue is about removing lazy builder callback info from big pipe placeholder IDs and moving it into a separate attribute data-big-pipe-replacement-callback-info.

As a follow up we could make this attribute optional. For example using a container parameter like twig.config.debug.

Remaining tasks

Refactor, test, decide.

📌 Task
Status

Needs work

Version

10.1 ✨

Component
BigPipe  →

Last updated about 13 hours ago

Created by

🇳🇱Netherlands casey

Live updates comments and jobs are added and updated live.
  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

    Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

  • 🇮🇳India ranjith_kumar_k_u Kerala

    Re-rolled #9

    error: patch failed: core/modules/big_pipe/tests/modules/big_pipe_test/src/BigPipePlaceholderTestCases.php:56
    error: core/modules/big_pipe/tests/modules/big_pipe_test/src/BigPipePlaceholderTestCases.php: patch does not apply
    error: patch failed: core/modules/big_pipe/tests/src/Functional/BigPipeTest.php:380
    error: core/modules/big_pipe/tests/src/Functional/BigPipeTest.php: patch does not apply

  • Status changed to Needs review over 1 year ago
  • Status changed to Needs work over 1 year ago
  • 🇺🇸United States smustgrave

    One of the remaining tasks is to decide the fix?

    What was the proposed solution that should be checked against the patch? Should be added to the issue summary please.

Production build 0.69.0 2024