Routing access checks can declare that they need the request by specifying needs_incoming_request: TRUE
\Drupal\Core\Access\AccessManager::check() is only passed the request when checking the incoming request. It is not passed a request when checking routes on output (like when rendering menu links, local tasks, etc).
If all of the access checks are dependent on the request, the result will be AccessResult::neutral() (aka access denied).
This is correct behavior, but can be confusing.
If all access checks are dependent on the request, warn the developer.
Currently, attempt to do that via a deprecation.
N/A
TBD
N/A
TBD
Needs work
10.1 ✨
Enhances developer experience.
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
Think this will need a test case to show the issue. Patch needs to be updated for the trigger_error pattern.