- Status changed to Needs review
8 months ago 6:11am 26 April 2024 - 🇮🇳India rajeshreeputra Pune
Requesting review, as stable release blocker issue are fixed. Once we get approval on this will cut the 2.0.0 stable release.
- 🇺🇸United States justcaldwell Austin, Texas
Just my 2 cents, but anyone who manages a site using Layout Builder would likely consider 🐛 Inline Blocks on Layout Builder Fail to Clone Correctly Needs work a stable release blocker. The fix had to be reverted, so the issue is open again.
- 🇮🇳India rajeshreeputra Pune
Certainly! Addressing the concern at hand, we can indeed consider making an exception for Layout Builder as part of our current development strategy. We understand that it holds a unique place in our ecosystem and requires special attention.
Additionally, your suggestion of creating a dedicated submodule to support entity cloning in conjunction with Layout Builder is a prudent measure. This approach allows us to safeguard against potential disruptions for other functionalities. By isolating this support into a separate module, we can ensure that if there are any specific compatibility issues or bugs, they can be managed without affecting the stability of the core system. This separation of concerns will facilitate smoother integration and provide a clearer path for maintenance and updates in the future.
Are there any other details or specific workflows you believe we should consider in this context?
- 🇮🇳India rajeshreeputra Pune
Regarding the concerns about the Layout Builder's issue( 🐛 Inline Blocks on Layout Builder Fail to Clone Correctly Needs work ) with the Entity Clone module, I believe we can address this issue independently rather than allowing it to delay the stable release. We will continue to monitor the issue closely while proceeding with the release candidate version.
- 🇮🇳India rajeshreeputra Pune
@colan, @joevagyok, @vpeltot, @Upchuk, @NickDickinsonWilde I would appreciate hearing your opinion on this matter.
- 🇺🇸United States justcaldwell Austin, Texas
I appreciate your willingness to have the discussion @Rajeshreeputra, and I don't want to overstate or belabor the point. That said, I think a stable release implies that all known critical/major issues around Drupal core functionality have been resolved. If there were incompatibilities with other contrib projects, I'd get it. But Layout Builder and translated entity references are both core-provided functionality with outstanding issues ( #3050027 🐛 Inline Blocks on Layout Builder Fail to Clone Correctly Needs work and #3258535 🐛 Translatable entity reference fields are not cloned correctly Needs work respectively) that can and do lead to data loss.
If you do proceed with a "stable" release, please consider adding a warning to the release notes (and, ideally, the project page) that Entity Clone should not be used in those cases. Thank you!
- 🇨🇦Canada colan Toronto 🇨🇦
My thoughts: Let's make it a beta release until core support is resolved.
- 🇮🇳India rajeshreeputra Pune
Sure, will cute the beta, along with 🐛 Cloneable entities functionality does not restrict content type entity Needs review and ✨ Option to clone content nodes including all comments Needs review .
- 🇮🇳India rajeshreeputra Pune
For issues 🐛 drupal 8.6: aliases don't save on cloned content. Needs work and 🐛 Translatable entity reference fields are not cloned correctly Needs work , we have requested a review from the community. Upon receiving the 'Reviewed & Tested by the Community' (RTBC) status, we will proceed with the merge and release.
This will leave us with only issue 🐛 Inline Blocks on Layout Builder Fail to Clone Correctly Needs work to resolve before we can proceed with a stable release.