The Needs Review Queue Bot β tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- Status changed to Needs review
about 1 year ago 3:57pm 4 September 2023 - last update
about 1 year ago Patch Failed to Apply - Status changed to Needs work
about 1 year ago 4:56pm 4 September 2023 - πΊπΈUnited States smustgrave
Will have to be rerolled for 11.x
Did not test or review yet.
- π³π±Netherlands ekes
@sam152
> Has the scope of this issue grown to include #3132022: Content moderation check does not take into account entity IDs being used by two content entities? We should either try to limit the scope of this issue and tackle the problems separately, or update the issue summary to describe all the scenarios that are being tested and the bugs that are being fixed.@acrazyanimal
> Thanks @Sam152. Yes I it does look like it covers the scenarios from the issue you linked above. Reviewing the comments in that issue's thread it looks like Alexj12 also increased the scope of that issue to cover the original issue here lol. I'm not sure what to do really. My inclination is to redefine this issue as an all encompassing issue since the tests are overlapping. I will think it over and possibly reduce this and contribute to the other issue.Looking I'm starting to get convinced https://www.drupal.org/project/drupal/issues/3132022#comment-15708738 π Content moderation check does not take into account entity IDs being used by two content entities Needs work that the query there is just going to throw too many false positives, for this, and the referenced issue, and for the other example I mention. So it might needs tweaking, not just filtering out revision ids.
- Status changed to Needs review
about 1 month ago 3:57pm 3 August 2024 - π³π±Netherlands ekes
In creating the branch https://git.drupalcode.org/issue/drupal-3179199/-/compare/11.x...3179199... against 11.x I ended up with the same code as @acrazyanimal in #9 it truly does fix both #3179199 and #3132022 but rewrote the tests against the present state of the class and found that to make them clear they should be separated I think. The tests are in the first commit, so can easily be run to confirm they do fail with the present code.
- Merge request !9062Content Moderation query errors when used with Workspaces. Issues: #3179199 and #3132022 β (Open) created by ekes
- Status changed to Needs work
about 1 month ago 4:04pm 3 August 2024 The Needs Review Queue Bot β tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request β . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
- Status changed to Needs review
about 1 month ago 4:21pm 3 August 2024 - π³π±Netherlands ekes
Adding a patch version of the MR for a patch ready snapshot.
- Status changed to Needs work
24 days ago 6:37pm 14 August 2024 - πΊπΈUnited States smustgrave
Appears to have 1 open thread for a small tweak.
- Status changed to Needs review
23 days ago 2:10pm 15 August 2024 - Status changed to Needs work
23 days ago 6:46pm 15 August 2024 - πΊπΈUnited States smustgrave
Believe the test needs to be updated too
1) Drupal\Tests\content_moderation\Kernel\WorkspacesContentModerationStateTest::testContentModerationWithoutDefaultRevisionsInWorkspaces Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: You have requested a non-existent service "entity_type_manager".
Appears super close!
- Status changed to Needs review
23 days ago 8:58am 16 August 2024 - π³π±Netherlands ekes
Serivce name typo should also be fixed. Tests pass I think.
- Status changed to Needs work
23 days ago 12:29pm 16 August 2024 - π·π΄Romania amateescu
Posted a few comments on the MR, once those are resolved I think this is good to go :)
- π·π΄Romania amateescu
I've closed π Content moderation check does not take into account entity IDs being used by two content entities Needs work as a duplicate and transferred over the credit.
- Status changed to Needs review
21 days ago 9:54am 18 August 2024 - π¨π·Costa Rica yuvania
I've tested the latest changes in my environment and everything seems to be working perfectly. Thanks everyone for the great work!
- Status changed to RTBC
20 days ago 9:24am 19 August 2024 - Status changed to Needs work
9 days ago 7:18am 30 August 2024 - Status changed to Needs review
9 days ago 8:19am 30 August 2024 - Status changed to RTBC
7 days ago 7:10pm 31 August 2024 - πΊπΈUnited States smustgrave
Tracked types doesn't seem bad. Debated "tracked content" but don't feel strong enough to request the change