- 🇬🇧United Kingdom catch
#9 doesn't remove the bc considerations - if there are contrib or custom modules relying on HTML IDs (they shouldn't), then they would potentially need to handle both versions then.
I think I would probably go back to #7 here and just make the change with a release note and change record. Leaving the RM review tag on to get a second opinion.
- 🇺🇸United States bnjmnm Ann Arbor, MI
No BC concerns the id requirements for HTML5 are more permissive. Any id supported by earlier HTML specs will continue to work in HTML 5.
Similarly, the additional CSS 2.1 id criteria being checked for in the new method does not introduce anything that isn't already disallowed by the HTML4 spec.
- Status changed to Needs work
over 1 year ago 11:59pm 30 January 2023 The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.