Use static TranslatableMarkup instead of trait for FieldBlockDeriver

Kicked off a D10 test run. If good will mark.

No errors. Think its a good refactoring

Not sure if anything else needs to be tested.

i'm not sure why we should be making this change. I'm not sure what's really wrong with the current code. @andypost can we close this as won't fix? Like even for performance I'm not sure because plugin manager definitions are cached.

Per for the response in #11

@andypost do you know if this is still needed?

@alexpott re #11 - it saves 2 function calls per each bundle for no reason (passed in string translation service reference is unused most of time)

It looks micro-optimization but when definitions are cached the string translation is (de)serialized for no reason

Also it makes the StringTranslationTrait trait unused (as class internal it allowed to simplify it)

Seems to have a number of test failures now. Though DrupalCi hasn't been as reliable lately.

converted

Seems like a simple enough change.

This would mean that \Drupal\Core\StringTranslation\TranslatableMarkup::__sleep is not working. Pretty sure we do not serialize the srting translation service and if we do then we should fix this more generically.