- 🇺🇸United States smustgrave
Kicked off a D10 test run. If good will mark.
- Status changed to RTBC
almost 2 years ago 11:21pm 31 January 2023 - 🇺🇸United States smustgrave
No errors. Think its a good refactoring
Not sure if anything else needs to be tested.
- Status changed to Needs review
almost 2 years ago 2:32am 16 February 2023 - 🇬🇧United Kingdom alexpott 🇪🇺🌍
i'm not sure why we should be making this change. I'm not sure what's really wrong with the current code. @andypost can we close this as won't fix? Like even for performance I'm not sure because plugin manager definitions are cached.
- Status changed to Postponed: needs info
almost 2 years ago 10:49pm 19 February 2023 - Status changed to Needs review
11 months ago 3:05pm 25 January 2024 - 🇫🇷France andypost
@alexpott re #11 - it saves 2 function calls per each bundle for no reason (passed in string translation service reference is unused most of time)
It looks micro-optimization but when definitions are cached the string translation is (de)serialized for no reason
Also it makes the
StringTranslationTraittrait unused (as class internal it allowed to simplify it) - last update
11 months ago 30,874 pass, 13 fail - last update
11 months ago 26,075 pass, 1,875 fail - Status changed to Needs work
11 months ago 9:15pm 28 January 2024 - 🇺🇸United States smustgrave
Seems to have a number of test failures now. Though DrupalCi hasn't been as reliable lately.
- last update
11 months ago Custom Commands Failed - Merge request !6366Draft: get rid of TranslatableMarkup in FieldBlockDeriver → (Open) created by andypost
- Status changed to Needs review
11 months ago 1:33pm 29 January 2024 - Status changed to RTBC
10 months ago 5:00pm 29 February 2024 - Status changed to Needs work
10 months ago 5:10pm 29 February 2024 - 🇬🇧United Kingdom alexpott 🇪🇺🌍
This would mean that \Drupal\Core\StringTranslation\TranslatableMarkup::__sleep is not working. Pretty sure we do not serialize the srting translation service and if we do then we should fix this more generically.
