W3C Validation: required attribute not allowed on fieldset tag

Open on Drupal.org →

Created on 2 October 2020, over 4 years ago

Updated 21 March 2024, 11 months ago

Problem/Motivation

Required fieldset tags generated for checkbox and radio button fields do not pass https://validator.w3.org/ validation. The following errors and and warnings are produced:

Error: Attribute required not allowed on element fieldset at this point.
Error: Element fieldset is missing required attribute role.
Warning: Attribute aria-required is unnecessary for elements that have attribute required.

Steps to reproduce

Go to admin/structure/types/manage/article/fields
Click Add field.
Choose List (text) from the Add a new field drop down and give the field a label.
Save
Add several values to the Allowed values list.
Save field settings.
Check Required Field
Save settings.
Go to admin/structure/types/manage/article/form-display
Change your field from Select list to Check boxes/radio buttons
Save
Go to node/add/article
View Page Source and submit it to validator.w3.org

Proposed resolution

Remove aria=required and required=required from fieldsets using template_preprocess_fieldset() in core.

Remaining tasks

tbd.

User interface changes

none.

API changes

none.

Data model changes

none.

Release notes snippet

tbd.

Additional Notes:

This was discovered via an issue for the Apigee Edge module in github.
I intentionally didn't include https://www.drupal.org/project/drupal/issues/2951317 🐛 Radios element missing "required" attribute Needs work and https://www.drupal.org/project/drupal/issues/2951317 🐛 Radios element missing "required" attribute Needs work in the Related Issues for this task because I believe this can be completed without answering the more complicated question of what to do with the actual input markup.
This issue was reported and fixed in webform.

🐛 Bug report

Status

Needs work

Version

11.0 🔥

Component

Last updated 7 days ago

Maintained by
🇺🇸United States @effulgentsia
🇺🇸United States @tim.plunkett

Created by

🇺🇸United States zakiya

Live updates comments and jobs are added and updated live.

Accessibility
It affects the ability of people with disabilities or special needs (such as blindness or color-blindness) to use Drupal.

wcag411

Incomplete comments

Sign in to follow issues

Merge Requests

!7115W3C Validation: required attribute not allowed on fieldset tag
Open
🇨🇦Canada Liam Morland
updated 8 months ago

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇮🇳India rhithwik
Any working patch?
Comment 11 months ago →
🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Liam Morland → made their first commit to this issue’s fork.
Merge request !7115Resolve #3174459: W3C Validation: required attribute not allowed on fieldset tag → (Open) created by Liam Morland
Status changed to Needs review 11 months ago5:28pm 20 March 2024
Comment 11 months ago →
🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
I have made a merge request with the patch in #12 plus the change suggested in #19.

Regarding #17, I can confirm that WCAG Success Criterion 4.1.1 has been removed from WCAG 2.2.
Pipeline finished with Success
11 months ago
Total: 504s
#124440
Status changed to Needs work 11 months ago1:55pm 21 March 2024
Comment 11 months ago →
🇺🇸United States smustgrave
Can we add simple assertions to be when and when it shouldn't appear.
Comment 8 months ago →
🇨🇦Canada kpaxman
Is this ticket now generically to fix elements that should not have the required attribute? (Because the MR includes additional fixes.)

If so, I will also note that Drupal generates this on input type="range", which also does not allow the required attribute. (https://www.w3.org/TR/wai-aria-1.2/#slider)
Pipeline finished with Canceled
8 months ago
Total: 430s
#208467
Pipeline finished with Success
8 months ago
Total: 513s
#208472

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024