Paragraph permission issue on Layout builder

Open on Drupal.org →

Created on 7 September 2020, over 4 years ago

Updated 15 March 2024, 10 months ago

Problem/Motivation

Parent issue: #3090200 🐛 Paragraph access check using incorrect revision of its parent, leading to issues editing and viewing paragraphs when content moderation is involved. Needs work

This is interesting issue at Comment#25 🐛 Paragraph access check using incorrect revision of its parent, leading to issues editing and viewing paragraphs when content moderation is involved. Needs work , let me talk something.

Paragraph permission flow on Layout builder: Paragraph -> Block Content -> Inline Block -> Node

(Inline Block just contacted Block Content and Node)

After Node revert, the [Block Content] on Node Layout also revert to old revision.

But on \Drupal\paragraphs\Entity\Paragraph::getParentEntity(), it always get the new [Block Content] revision.

On Drupal\layout_builder\EventSubscriber\SetInlineBlockDependency::isBlockRevisionUsedInEntity(), it want to match [Block Content] revision.

But on Node, [Block Content] is old, Paragraph provided is new, cannot match, so no permission on Paragraph.

Steps to reproduce

- Prepare a Block Type with paragraph.
- Create a content.
- Add a Inline Block on Layout, save.
- Go back to Layout, edit the Inline Block above, save.
- Goto Revisions, revert revision to created at Step 2 .
- Goto Layout, the Inline Block content was missiong, and the Paragraph permission was missing.

Proposed resolution

Root resolution:
- Paragraph add parent_revision filed to get parent entity by revision_id. (But this need Paragraph team support and have old data problem)

Temporary solution:
- Judge Block id used in entity at \Drupal\layout_builder\EventSubscriber\SetInlineBlockDependency

Remaining tasks

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

None.

🐛 Bug report

Status

Closed: duplicate

Version

11.0 🔥

Component

Layout builder →

Last updated 4 days ago

Maintained by
🇺🇸United States @tedbow
🇺🇸United States @dyannenova
🇺🇸United States @tim.plunkett

Created by

🇨🇳China Oscaner

Live updates comments and jobs are added and updated live.

Needs Review Queue Initiative
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.

Incomplete comments

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment almost 2 years ago →
🇺🇸United States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

This will need a test case to show the issue to move forward.
Also new functions will need a typehint

Did not test patch.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
29,446 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
29,201 pass, 26 fail
Status changed to Closed: duplicate 10 months ago6:30pm 15 March 2024
Comment 10 months ago →
🇷🇴Romania amateescu
Drupal\layout_builder\EventSubscriber\SetInlineBlockDependency::isBlockRevisionUsedInEntity() works as intended, the problem is within Paragraphs which doesn't use the correct revision when trying to determine the parent entity.

Closing as a duplicate of 🐛 Paragraph access check using incorrect revision of its parent, leading to issues editing and viewing paragraphs when content moderation is involved. Needs work .

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024