Using Image Widget Crop in responsive images does not refresh webp image

Created on 19 June 2020, over 4 years ago
Updated 15 August 2023, over 1 year ago

ImageStyleDownloadController::deliver is not triggered when you update crop for your image and visit a page with responsive images to see updated webp image. Unfortunately webp image is only generated once which is not correct in case of updating existing image.

πŸ› Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡¦Ukraine nginex

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ͺπŸ‡ΈSpain gxleano CΓ‘ceres

    Hi everyone!!

    I was be able to reproduce this bug combining Image Widget Focal Point in responsive images, webp and media.

    I've tested the MR and everything works as expected for me.

    Step by step testing

    1. As admin user, go to Media library.
    2. Edit whatever media which is using the problematic media type (Using widget focal point).
    3. Update the positioning in the focal point image.
    4. Save the media.

    Afterwards, the webp images are generated sucessfully.

  • πŸ‡¨πŸ‡¦Canada Nathan Tsai

    For some reason, this issue has arisen again after updating to PHP 8.1 and Drupal 9.5.5.

    I had to upgrade image_widget_crop to the latest version and update the patch in πŸ› Image style derivative flush missing on update Needs review to #17 to get it working again.

  • πŸ‡―πŸ‡΄Jordan Rajab Natshah Jordan

    Tested this fix by patch #34. It's working.
    Thank you :)

  • πŸ‡ΊπŸ‡ΈUnited States pbabin

    We're using patch #34 with image widget crop and responsive images. It's working like a charm. Without it the images were not displaying correctly. Thank you for this fix.

  • πŸ‡³πŸ‡±Netherlands Drumanuel

    As reported by others: Tested patch 34 with Focal Point module and all is working as expected.
    webp 1.0.0-beta7
    focal_point 1.5.0
    core 9.5.9

    • mandclu β†’ committed dba007dc on 8.x-1.x
      Issue #3153137 by nginex, tdroden, GaΓ«lG, MintLucky, StryKaizer,...
  • Status changed to Fixed over 1 year ago
  • πŸ‡¨πŸ‡¦Canada mandclu

    I'm a little concerned that the reported issue was specific to using Focal Point or other modules that provide a UI to crop images, but the provided fix resets all webp derivatives on every entity save, whether or not such an image is in use (or its values changed). That said, being more selective would likely require a lot more complexity.

    Merged in, thanks for everyone's work on this.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024