Replace use of whitelist/blacklist in \Drupal\Core\Extension classes

Created on 12 June 2020, over 4 years ago
Updated 5 September 2024, 4 months ago

Problem/Motivation

Let's remove usage of "blacklist" and "whitelist" in \Drupal\Core\Extension classes and their tests

They are:

  • An historic bad labelling of people
  • Provide no context: "what is listed in them"?

Proposed resolution

  • Fix Drupal\Core\Extension\Discovery\RecursiveExtensionFilterIterator:
    • Rename $blacklist to $skippedFolders
    • Rename $whitelist to $allowedExtensionTypes
  • Fix comments in related code (core/lib/Drupal/Core/Extension/ExtensionDiscovery.php)

Remaining tasks

  1. Finish fixing the patch (final points in #15)
  2. Final reviews
  3. RTBC
  4. Commit
  5. Publish CR

User interface changes

None

API changes

Not API, but we're renaming some protected array members in Drupal\Core\Extension\Discovery\RecursiveExtensionFilterIterator:

  • $blacklist is replaced with $skippedFolders
  • $whitelist is replaced with $allowedExtensionTypes

Data model changes

N/A

Release notes snippet

N/A

πŸ“Œ Task
Status

Fixed

Version

9.1

Component
BaseΒ  β†’

Last updated 1 day ago

Created by

πŸ‡¬πŸ‡§United Kingdom alexpott πŸ‡ͺπŸ‡ΊπŸŒ

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024