- 🇺🇸United States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
Patch #12 had an error on D10
- @cburschka opened merge request.
- 🇨🇭Switzerland cburschka
I've backdated the previous patches into a fork + merge request to work with it more easily.
I suspect the largest problem is the use of file_create_url(), which was replaced with a service in D10.
- Status changed to Needs review
almost 2 years ago 6:18pm 2 February 2023 - @cburschka opened merge request.
- 🇨🇭Switzerland cburschka
Unfortunately I don't see an easy way to run tests on the testonly branch without opening a second MR.
- 🇨🇭Switzerland cburschka
The test-only patch is failing as designed. This looks ready for review.
- Status changed to Needs work
almost 2 years ago 8:31pm 2 February 2023 - 🇺🇸United States smustgrave
Seems MR 3373 has some failures.
Hiding the files to avoid confusion.
As far as tests-only you are spot on for what I've seen others do. They open a separate MR for the tests-only. If you uploaded a test-only patch and then did an MR after that not entirely sure what happens.
- Status changed to Needs review
almost 2 years ago 9:28pm 2 February 2023 - 🇨🇭Switzerland cburschka
MR 3373 is supposed to have failures, that's the test-only one :D
- Status changed to Needs work
almost 2 years ago 6:15pm 2 March 2023 - 🇺🇸United States smustgrave
That's my mistake
Could the issue summary be updated though with steps to reproduce this, the proposed solution, maybe before/after screenshots could help. Helps the reviewer and committer.