- 🇺🇸United States mherchel Gainesville, FL, US
Unpostponing (poning?) since Drupal 10 no longer supports IE11.
- Status changed to Needs review
over 1 year ago 3:59am 6 April 2023 - 🇮🇳India gauravvvv Delhi, India
Removed
role="article"
from<article>
tag. Attached patch for same. please review - 🇮🇳India omkar_yewale Mumbai
After manually reviewing #39 Patch, role="article" Removed from tag.
- 🇮🇳India Akshay kashyap
Verified and tested patch #39 on Drupal 10.1.x-dev. Patch was applied successfully and looks good to me.
Testing steps:
1. install Drupal 10.1.x
2. Check filesUserPictureTest.php
&node. module
And find [role="article"] attribute.
3. apply the patch.
4. Observe that the[role="article"] attribute
removed from the both files.Testing Result:
1. [role="article"] attribute was removed after applying the patch. Screenshots are attached for reference:
Can be moved to RTBC" - Status changed to RTBC
over 1 year ago 3:01pm 6 April 2023 - 🇺🇸United States smustgrave
As mentioned in https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/ar...
Don't use role="article". Instead use the element.
So this change looks good.
Not sure about the change record. If someone has overridden the template would say they have taken the responsibility upon themselves to be accessible. Even if they're embedding this just makes their site better.
But could be wrong.
The last submitted patch, 39: 3117230-38.patch, failed testing. View results →
- last update
over 1 year ago 29,202 pass - last update
over 1 year ago 29,283 pass - last update
over 1 year ago 29,300 pass - last update
over 1 year ago 29,302 pass - last update
over 1 year ago 29,304 pass - last update
over 1 year ago 29,359 pass 46:03 42:49 Running- last update
over 1 year ago 29,366 pass - Status changed to Fixed
over 1 year ago 11:31am 2 May 2023 - 🇬🇧United Kingdom catch
Agreed with @smustgrace on the lack of need for a change record, this is just removing something from preprocess.
I think we're find to go ahead here now that IE11 is no longer supported. I did copy @andrewmcpherson's comment from here over to 🐛 Remove redundant WAI-ARIA role attributes from , , , , and elements Needs work since we might want to be a bit more cautious there.
Automatically closed - issue fixed for 2 weeks with no activity.