Fix the warnings/errors reported by PHP_CodeSniffer

Unfortunately these patches tend to need a lot of rerolls... and this one apparently does.

Rerolled the latest patch @mcdruid. Please review and merge.

Since the issue summary suggest to use phpcs --standard=Drupal to fix the coding standard errors, it should also show which warnings/errors PHP_CodeSniffer reports.

The status is also for the issue summary that needs to be updated.

Thanks - seems there were quite a few other Code Sniffer fixes not covered by this patch.

I've tried to do all of them in this patch.. which I expect will now conflict with changes being made in 📌 Add phpcs and drupal-check fixes Needs work but unfortunately these issues that make a lot of small changes are always tricky to land.

If this patch passes tests, we'll get these committed and all of the current Code Sniffer problems will be fixed.

I realise there's been quite a lot of discussion in this issue about the changes like this:

-      $x_frame_allow_from = $form_state->getValue(['seckit_clickjacking', 'x_frame_allow_from']);
+      $x_frame_allow_from = $form_state->getValue([
+        'seckit_clickjacking',
+        'x_frame_allow_from',
+      ]);

Although I agree that the change doesn't necessarily improve readability here, it's much easier overall to maintain the code if we have completely clean results from Code Sniffer, as opposed to maintaining a list of checks that we've decided to ignore.

The current standards do mention splitting arrays onto multiple lines like this when otherwise the line length exceeds 80:

https://www.drupal.org/docs/develop/standards/php/php-coding-standards#a... →

... if the line declaring an array spans longer than 80 characters (often the case with form and menu declarations), each element should be broken into its own line, and indented one level ...

Are these lines declaring arrays? We could debate that, but as mentioned I'll go back to the argument that a totally clean Code Sniffer result is desirable for ease of maintenance.

Thank you everybody that worked on this.

Automatically closed - issue fixed for 2 weeks with no activity.