Use $this->request in ViewsExecutable::getExposedInput() consistently

it was added in #2068471: Normalize Controller/View-listener behavior with a Page object →

The request is protected property so no reason in extra function call

Probably better to move other changes to separate issue (a-la fix request usage in views)

According to the jenkins console, this produces quite some test failures in tests based on both KTB and BTB. Guess this is blocked by 📌 Add the session to the request in KernelTestBase, BrowserTestBase, and drush Fixed .

The last submitted patch, 2: 3109971-2.diff, failed testing. View results →

The last submitted patch, 4: 3109971-4.patch, failed testing. View results →

Let's see combined patch

@andypost: Take a look at #3110291: Test-only issue for session on request in BrowserTestBase → .

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened → , as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule → and the Allowed changes during the Drupal core release cycle → .

Drupal 9.5.0-beta2 → and Drupal 10.0.0-beta2 → were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule → and the Allowed changes during the Drupal core release cycle → .

Drupal 9.4.0-alpha1 → was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule → and the Allowed changes during the Drupal core release cycle → .

Drupal 9.3.0-rc1 → was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule → and the Allowed changes during the Drupal core release cycle → .

Drupal 9.2.0-alpha1 → will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule → and the Allowed changes during the Drupal core release cycle → .

Drupal 9.1.0-alpha1 → will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule → and the Allowed changes during the Drupal 9 release cycle → .

Proper status and version, blocked on 📌 Add the session to the request in KernelTestBase, BrowserTestBase, and drush Fixed

I guess there is nothing to do here anymore. Code in ViewExecutable was fixed in 🐛 Feature "Remember the last selection" for views exposed filters doesn't work anymore Fixed .

re-opening to narrow scope

All the code changes look good to me.
For me it is RTBC.

Decided not to backport just in case someone is doing something unexpected with Views and this breaks their expectations, this isn't critical anyway, just a nice cleanup.

Committed 1c32ca8 and pushed to 11.x. Thanks!

andypost → closed merge request !5964

Automatically closed - issue fixed for 2 weeks with no activity.