Enhance hash_salt documentation in default.settings.php

Patch from #13 is the same as #7 but with the wrong extension. I'm hiding it and adding this example to #3339883: Employees of Dotsquares are posting mass re-roll patches which are invalid and/or incomplete → . I would recommend deleting this file.

I would move this to RTBC. Patch applies cleanly on 10.1.x, nobody said anything against the change.

The situation mstrelan describes is real, but it comes from a bar practice and I others issues arise when you use itok on the body. I don't think it is enough to block this change. Also, I don't think sysadmins are going to change their current setup of a running site because this little comment change,

Please ignore patch #13 and @tunic thanks for informing me. I will take care of it & never repeat it again

Change in #7 seems small and easy enough. Lets see what the committers say.

Fail is genuine, need to update the scaffold file too

#19 is right, we need to patch "/core/assets/scaffold/files/default.settings.php" file, I totally forgot about scaffolding in #16, sorry.

Since original patch author (roderik) seems inactive I'm adding a patch with that change.

The last submitted patch, 20: 3107548-20-enhance-hash-salt-doc.patch, failed testing. View results →

Ok, I added a trailing space :(

One error is from that space char, but the other seems unrelated to this patch:

1) Drupal\Tests\ckeditor5\FunctionalJavascript\CKEditor5AllowedTagsTest::testMediaElementAllowedTags
Behat\Mink\Exception\ElementNotFoundException: Form field with id|name|label|value "filters[media_embed][settings][allowed_view_modes][view_mode_2]" not found.

/var/www/html/vendor/behat/mink/src/Element/TraversableElement.php:207
/var/www/html/core/modules/ckeditor5/tests/src/FunctionalJavascript/CKEditor5AllowedTagsTest.php:386
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

Let's try again, without that trailing space.

Forgot patch!

Looks good, thanks for addressing #19, @tunic

The last submitted patch, 23: 3107548-23-enhance-hash-salt-doc.patch, failed testing. View results →

Again, strange failures related to CKEditor tests:

Testing Drupal\Tests\ckeditor5\FunctionalJavascript\CKEditor5AllowedTagsTest
.....E.                                                             7 / 7 (100%)

Time: 02:11.514, Memory: 4.00 MB

There was 1 error:

1) Drupal\Tests\ckeditor5\FunctionalJavascript\CKEditor5AllowedTagsTest::testMediaElementAllowedTags
Behat\Mink\Exception\ElementNotFoundException: Form field with id|name|label|value "filters[media_embed][settings][allowed_view_modes][view_mode_2]" not found.

/var/www/html/vendor/behat/mink/src/Element/TraversableElement.php:207
/var/www/html/core/modules/ckeditor5/tests/src/FunctionalJavascript/CKEditor5AllowedTagsTest.php:386
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

I've triggered a retest but I don't have faith, it will probably fail again.

Retesting worked!
Moving to Needs Review.

Putting back to RTBC since it was random failure

Committed and pushed to 10.1.x, thanks! I tried to credit everyone who added something to the discussion here.

Automatically closed - issue fixed for 2 weeks with no activity.