Remove uses of the [user:name] token

1. +++ b/core/lib/Drupal/Core/Utility/Token.php
   @@ -371,16 +371,16 @@ public function generate($type, array $tokens, array $data, array $options, Bubb
   -   *     'author:name' => '[node:author:name]',
   +   *     'author:name' => '[node:author:account-name]',
   

   I think key should also changed to 'author:account-name'

2. +++ b/core/lib/Drupal/Core/Utility/Token.php
   @@ -371,16 +371,16 @@ public function generate($type, array $tokens, array $data, array $options, Bubb
   -   *   $results == array('name' => '[node:author:name]');
   +   *   $results == array('name' => '[node:author:display-name]');
   

   that's inconsistent with above(

3. +++ b/core/modules/system/tests/src/Kernel/Token/TokenReplaceKernelTest.php
   @@ -62,6 +62,8 @@ public function testClear() {
        // No user passed in, should be untouched.
   +    $source .= '[user:account-name]';
   +    // Keep old test to token also.
        $source .= '[user:name]';
   

   it may need separate legacy/deprecation test

Added changes mentioned in the above comment.

The last submitted patch, 49: 3097462-49.patch, failed testing. View results →

Please include an interdiff with patches

Your patch seems to be missing all the changes

Here's a new patch based on #47, and regarding #48:

it may need separate legacy/deprecation test

I wasn't able to address this one, according to #46, we'll need a followup to properly deprecate the old token, and since the code is not deprecating anything right now, I think we can have this test created on the followup issue, what do you think?

Moving back NR

That makes sense to me.

Tagging for a followup for that ticket to be created.