Remove outdated @todo from the Locale module

Created on 6 November 2019, over 5 years ago
Updated 23 January 2023, about 2 years ago

The code for locale_js_alter() contains the following comment.

  // @todo Remove this in https://www.drupal.org/node/2421323.
  $files = [];
  foreach ($javascript as $item) {
    if (isset($item['type']) && $item['type'] == 'file') {

      // Ignore the JS translation placeholder file.
      if ($item['data'] === 'core/modules/locale/locale.translation.js') {
        continue;
      }
      $files[] = $item['data'];
    }
  }

Given that #2421323: Parse js files from library definitions during rebuild to minimize variable_set() calls โ†’ has been closed time ago, I guess that either:

  • The comment needs to be removed
  • The code needs to be removed

I quickly read the other issue, but I cannot say which is the correct action.

๐Ÿ“Œ Task
Status

Fixed

Version

10.1 โœจ

Component
Localeย  โ†’

Last updated 4 days ago

Created by

๐Ÿ‡ฎ๐Ÿ‡นItaly apaderno Brescia, ๐Ÿ‡ฎ๐Ÿ‡น

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024