- 🇩🇪Germany FeyP
Is the sensible solution here to disable changing the machine name of the view in this case instead?
If possible, I think it would be better to update the display id of the attachments to the new display id during save.
- First commit to issue fork.
- Status changed to Needs review
about 1 year ago 9:06am 30 April 2024 - First commit to issue fork.
- Status changed to RTBC
about 1 year ago 1:50pm 6 May 2024 - 🇺🇸United States smustgrave
Ran test-only feature here https://git.drupalcode.org/issue/drupal-3091003/-/jobs/1475951 which shows the coverage
Applied a nitpicky change for the test.
Wish there was a hasAttached function call vs calling getAttachedDisplays() every time but definitely not in scope here. Changes does address the issue.
-
longwave →
committed 72e1a979 on 10.2.x
Issue #3091003 by sukr_s, smustgrave, RaphaelBriskie, FeyP, borisson_:...
-
longwave →
committed 72e1a979 on 10.2.x
-
longwave →
committed 8367edf3 on 10.3.x
Issue #3091003 by sukr_s, smustgrave, RaphaelBriskie, FeyP, borisson_:...
-
longwave →
committed 8367edf3 on 10.3.x
-
longwave →
committed d45f21b7 on 10.4.x
Issue #3091003 by sukr_s, smustgrave, RaphaelBriskie, FeyP, borisson_:...
-
longwave →
committed d45f21b7 on 10.4.x
-
longwave →
committed 8a7586f8 on 11.0.x
Issue #3091003 by sukr_s, smustgrave, RaphaelBriskie, FeyP, borisson_:...
-
longwave →
committed 8a7586f8 on 11.0.x
-
longwave →
committed 26e5ef20 on 11.x
Issue #3091003 by sukr_s, smustgrave, RaphaelBriskie, FeyP, borisson_:...
-
longwave →
committed 26e5ef20 on 11.x
- Status changed to Fixed
about 1 year ago 3:35pm 10 May 2024 - 🇬🇧United Kingdom longwave UK
A nice straightforward fix and test. I did wonder what else breaks if you change a machine name - should we have another layer of indirection such as UUIDs that never change? - but this will solve the immediate problem.
Backported to 10.2.x as an eligible bug fix.
Committed and pushed 26e5ef207a to 11.x and 8a7586f81e to 11.0.x and d45f21b776 to 10.4.x and 8367edf312 to 10.3.x and 72e1a9792b to 10.2.x. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.