- ๐ธ๐ชSweden Peter Tรถrnstrand
I'm using this patch besides the one in #26 to at least get this thing working descently. But this is by no means done.
- ๐ง๐ชBelgium Ludo.R Brussels
Re. #27
I just ran into the same issue, I guess modifying
MenuBlock::getDerivativeActiveTrailIds()
should be enough.protected function getDerivativeActiveTrailIds() { $menu_id = $this->getDerivativeId(); // => If menu_id = "multiple_menu_block", then do custom logic. return array_filter($this->menuActiveTrail->getActiveTrailIds($menu_id)); }
In the meantime I'm using classic Menu blocks (from core) and not the multiple one.
- ๐ซ๐ฎFinland mitechworld
Update the patch to support versions equal/greater than v1.8
- ๐ต๐นPortugal jrochate
Currently none of the patches above works: 1.11
- First commit to issue fork.
- last update
28 days ago Unable to generate test groups - ๐ต๐นPortugal lolgm
I created !MR22 for version 1.11, based on previous patches.
I also implemented a proposed solution to the block title, problem referred in #27 and #28. - last update
28 days ago 11 pass - last update
26 days ago Unable to generate test groups - ๐ซ๐ฎFinland mitechworld
mitechworld โ changed the visibility of the branch 8.x-1.x to active.
- Status changed to Needs review
6 days ago 9:52am 20 June 2024 - last update
6 days ago Patch Failed to Apply - last update
6 days ago Patch Failed to Apply - ๐ง๐ชBelgium weseze
MR22 works fine. (tried the patch from it against latest release)
Can we get feedback from the maintainers?
- ๐ต๐นPortugal lolgm
@weseze Thanks for the feedback.
Using this functionality I found two use cases where the implementation was incomplete.
1st - When a node is present in more than one menu, it is not possible to "prioritize" a menu to be the active one.
2nd - When the current node is not present in any menu, and if the option "Hide on pages not included in menu" is not activated, the expected behavior is to render the default menu, however the default menu in the multiple block is the first menu from the configuration list, may not be the intended default.
These two limitations occur due to the block configuration format being just a table with select, not sortable.
In this way, I converted the selection table into a table with the option of dragging, so that it is now possible to select the menus you want and classify them in order of "priority".
Therefore, the first menu selected will also be the default menu if there is no active menu on the current node.Attention!!!
This is a breaking change.
To be able to make this change, the format in which the selected menus were being saved in the block configuration changed, according to my tests, the only problem is having to configure the multiple menu blocks again. - last update
about 17 hours ago Patch Failed to Apply - last update
about 16 hours ago Composer require failure - ๐ต๐นPortugal lolgm
Patch #42 is incomplete, this is the patch with changes #41.