Using the "Is not one of" operation on a moderation workflow field filters out only the content types that don't have moderation enabled.
Example:
value1
value2
value3
value4
value5
value6
If I select "Is not one of" value3 and value5
I get:
value1
value2
value3
value4
value5
value6
I expect:
value1
value2
value4
value6
The problem is here:
// The values are strings composed from the workflow ID and the state ID, so
// we need to create a complex WHERE condition.
$field = new Condition('OR');
foreach ((array) $this->value as $value) {
list($workflow_id, $state_id) = explode('-', $value, 2);
$and = new Condition('AND');
$and
->condition("$this->tableAlias.workflow", $workflow_id, '=')
->condition("$this->tableAlias.$this->realField", $state_id, $operator);
$field->condition($and);
}
$this->query->addWhere($this->options['group'], $field);
The whole $field (as a group) should be negated instead of negating the second and condition in the cycle.
Needs work
9.5
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Attached patch against Drupal 10.1.x
Patch #2 is not applied for Drupal 10.1.x so Inter-diff file is not added.
Please read the comments. The issue was tagged for issue summary update and tests neither of which happened