- π©πͺGermany Anybody Porta Westfalica
Let's automate that tests to ensure it works now and in the future.
- π©πͺGermany Anybody Porta Westfalica
@greggles what do you think, the tests might be quite heavy due to the Drupal Commerce dependencies and configuration. Should we merge it as-is or better invest the time for the test?
@Grevil what do you think? - πΊπΈUnited States greggles Denver, Colorado, USA
I don't have a strong opinion on it. If someone doing the work is willing to do it then that seems great, but I agree it could be hard to get to testing this.
- π«π·France andypost
I bet it's not a hard job to add testing,
composer req --dev drupal/commerce
should work now instead oftest_dependencies
(used by DrupalCI) - Status changed to Needs work
9 months ago 2:31pm 9 October 2023 - First commit to issue fork.
- @grevil opened merge request.
- π©πͺGermany Grevil
Alright all done! @Anybody, should we show the message only if the "Email registration guest registration after checkout" pane is enabled, or also when the "Guest registration after checkout" is enabled?
- Assigned to Anybody
- Status changed to Needs review
9 months ago 9:34am 12 October 2023 - Assigned to Grevil
- Status changed to Needs work
9 months ago 9:44am 12 October 2023 - π©πͺGermany Grevil
Checking both panes makes only sense. Creating tests now.
- Issue was unassigned.
- Status changed to Needs review
9 months ago 1:02pm 12 October 2023 - π©πͺGermany Grevil
Alright, I refactored some of the existing test helping methods, adjusted Testclass names / folder structure and added the required test! Please review! π
- Status changed to Needs work
9 months ago 1:16pm 12 October 2023 - Status changed to Needs review
9 months ago 2:20pm 12 October 2023 - Status changed to RTBC
9 months ago 2:37pm 12 October 2023 - π©πͺGermany Anybody Porta Westfalica
Thanks @Grevil for taking the time! :)
-
Anybody β
committed 362fe061 on 8.x-1.x authored by
Grevil β
Issue #3081857 by Grevil, lkacenja: Login checkout pane should show...
-
Anybody β
committed 362fe061 on 8.x-1.x authored by
Grevil β
- Status changed to Fixed
9 months ago 2:38pm 12 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.