- Status changed to Needs work
almost 2 years ago 11:57pm 30 January 2023 The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
almost 2 years ago 11:48am 7 February 2023 The last submitted patch, 53: 3080853-53.patch, failed testing. View results →
- Status changed to Needs work
almost 2 years ago 5:08pm 7 February 2023 - 🇺🇸United States smustgrave
Can you please provide an interdiff so we can see the change.
- 🇧🇷Brazil lucassc Rio de Janeiro
Providing an interdiff between the patch in #53 and the patch before this in #48.
- First commit to issue fork.
- 🇳🇿New Zealand quietone
The next step here is to convert to an MR, which is suitable for a novice.
- Merge request !10137Issue #3080853: Applied the patch on 11.x-dev. → (Open) created by chhavi.sharma
- 🇮🇳India chhavi.sharma
Applied the changes of patch manually and created an MR against 11.x branch.
- 🇳🇿New Zealand quietone
@chhavi.sharma, thanks for converting to an MR. Unfortunately, the changes to the test file were lost in the conversion. That is probably why the tests are failing. Can you add those changes to the MR?
- 🇮🇳India chhavi.sharma
@quietone I tried to add test file changes but the
UpdateSemvertestBase.php
contains 70 lines only but the suggested changes in the patch are at line 158 so I am not sure of the code in between those lines. That is why I didn't applied those changes manually.
- 🇮🇳India chhavi.sharma
@quietone The patch was intented for 10.1.x branch but in the 11.x branch, the test file is only 70 lines long and all the testing functions which were available in the 10.1.x branch are missing from 11.x branch. So the patch changes can not be applied to the test file directly. So should I add all the missing functions and lines of code to the test file which are not included in the 11.x branch?