Remove invalid iframe attributes from oembed field formatter

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Attaching a patch for drupal 10, In drupal 10 stable theme is no longer present hence removed the changes related to that.

Attaching a patch for drupal 10.1.x version

I rerolled the patch in #22 for D11 and converted it to an MR.

Left some comments on MR.

@smustgrave What are we adding an upgrade path for? Unless I'm missing something there are no configuration changes. The values for those attributes were hard-coded.

If they're not being added to configuration then can ignore that.

The comments on the MR have been answered. I don't believe any changes are necessary.

works for me, thanks.

Thanks for taking a look @nod_

Tested out by using a stark theme since Olivero disables media modules ombed library.
Tested with and without the patch and can confirm I'm not seeing any visual regression from removing the attributes.

LGTM

Committed and pushed 655cb760fc to 11.x and 0bc782b1f8 to 11.0.x and 24b4a8ea8e to 10.4.x and 04fb2d1d1e to 10.3.x. Thanks!

diff --git a/core/modules/media/src/Plugin/Field/FieldFormatter/OEmbedFormatter.php b/core/modules/media/src/Plugin/Field/FieldFormatter/OEmbedFormatter.php
index 132248d8fc..70047c8983 100644
--- a/core/modules/media/src/Plugin/Field/FieldFormatter/OEmbedFormatter.php
+++ b/core/modules/media/src/Plugin/Field/FieldFormatter/OEmbedFormatter.php
@@ -22,7 +22,6 @@
 use Drupal\media\Plugin\media\Source\OEmbedInterface;
 use Symfony\Component\DependencyInjection\ContainerInterface;
 
-// cspell:ignore allowtransparency
 /**
  * Plugin implementation of the 'oembed' formatter.
  *

Made the change above on commit because allowtransparency is no longer in the file.

Automatically closed - issue fixed for 2 weeks with no activity.