Umami changes the admin interface language based on the current page

The blocked was merged and released already, so let's see if patch still applies.

The Needs Review Queue Bot → tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

Rerolled and converted to a MR.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

I've created the "spanish-speakers" author and editor. Had to fix the user creation logic a bit for allowing that. Thought about moving that info from hardcoded to a csv as we do with content, but probably overkill unless we need more custom data in the future.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Left a comment on MR.

This feels like a bug though. Is it just Umami it's happening on or a bug with a core module? Believe we should have test coverage for the bug.

For the +Needs tests tag, I don't think we have that requirement on Umami.

@smustgrave

This feels like a bug though. Is it just Umami it's happening on or a bug with a core module? Believe we should have test coverage for the bug.

Not a bug, just different configuration defaults than standard profile. We want to demo in Umami that this is possible, but won't make sense to have that as default for e.g. the standard profile.

From slack sounds like @markconroy doesn't think this needs tests

@Berdir I agree that our language negotiation configuration form needs a lot of work but I don't think that should hold us back making umami a good example.

Committed 0e6acad and pushed to 11.x. Thanks!
Committed 1837cf5 and pushed to 10.3.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.