- πΊπ¦Ukraine andriy khomych
Hi @MegaChriz, this looks like an interesting feature.
It sounds like that a feature to override the whole mapping would suit better in a contrib/custom module, because it could be complex to maintain it in the long run: any feature that is related to mapping would then need tests for both the regular mapping form as the overridden mapping form.
Why not make this a submodule to enable on-demand? It doesn't look too complicated to have a separate contrib module.
- πΊπ¦Ukraine andriy khomych
Hi @MegaChriz, as it was suggested in the ticket, I decided to come up with a contrib solution.
- Status changed to Needs review
7 months ago 10:06am 24 April 2024 - last update
7 months ago Patch Failed to Apply - last update
7 months ago 110 pass, 5 fail The last submitted patch, 8: 3060977-8-allow-override-xpath-mappings-for-alpha4.patch, failed testing. View results β
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- Status changed to Active
7 months ago 3:52am 26 April 2024 - π―π΅Japan ptmkenny
Setting this to active so that hopefully it gets looked at.
- Status changed to Needs review
7 months ago 7:09am 26 April 2024 - πΊπ¦Ukraine andriy khomych
Hey Patrick Kenny, as it was said here https://www.drupal.org/project/feeds_ex/issues/3060977#comment-15081492 β¨ Allow overriding xpaths when creating feed Active
we have now a contrib module - https://www.drupal.org/project/feeds_ex/issues/3060977#comment-15081492 β¨ Allow overriding xpaths when creating feed Active
Feel free to check it and open issues on the related module page. And if you are fine with it, please, add related note to this issue. - π―π΅Japan ptmkenny
@Andriy Khomych Yes, that's what I meant by my comment in #13. Because there is a patch for this issue, when you set it to "Needs review", the Drupal bot set the status back to "Needs work" because the tests on the patch (not related to your module) failed.
- π―π΅Japan ptmkenny
I think we should link feeds_ex_xml_mapping on the project page before marking this fixed.