- Merge request !4605Issue #3053773: Move shutdown functions into the shutdown handler class. β (Open) created by voleger
- last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Build Successful - last update
over 1 year ago Build Successful - last update
over 1 year ago Build Successful - last update
over 1 year ago 30,048 pass - last update
over 1 year ago 30,048 pass - Status changed to Needs review
over 1 year ago 2:50pm 18 August 2023 - Status changed to RTBC
over 1 year ago 5:05pm 30 August 2023 - πΊπΈUnited States smustgrave
Applied the MR and searched for drupal_register_shutdown_function and seems all instances have been replaced.
Only question is the formatting of the trigger_errors. Not sure it matters but wanted to flag for committers.
- last update
over 1 year ago Build Successful - last update
over 1 year ago 30,136 pass - last update
over 1 year ago 30,136 pass - last update
over 1 year ago 30,137 pass - last update
over 1 year ago 30,147 pass - last update
over 1 year ago 30,147 pass - last update
over 1 year ago 30,149 pass - last update
over 1 year ago 30,151 pass 14:44 12:16 Running- last update
over 1 year ago 30,162 pass - last update
over 1 year ago 30,169 pass - last update
about 1 year ago 30,169 pass - last update
about 1 year ago 30,206 pass - last update
about 1 year ago 30,364 pass - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - Status changed to Needs work
about 1 year ago 8:53am 20 October 2023 - π¬π§United Kingdom alexpott πͺπΊπ
I've added some comments to the MR.
- Status changed to Needs review
about 1 year ago 3:57am 2 December 2023 - Status changed to RTBC
about 1 year ago 8:55pm 3 December 2023 - πΊπΈUnited States smustgrave
feedback appears to have been addressed. Left a note in IS that an api change is being proposed.
- last update
about 1 year ago 30,689 pass - last update
about 1 year ago 30,689 pass - last update
about 1 year ago 30,697 pass - πΊπ¦Ukraine voleger Ukraine, Rivne
I updated CR per Slack feedback. Also updated Error::shutdownExceptionHandler definition.
- last update
about 1 year ago 30,699 pass - last update
about 1 year ago 30,713 pass 14:45 11:17 Running- last update
about 1 year ago 30,765 pass - last update
about 1 year ago 30,767 pass - last update
about 1 year ago 25,906 pass, 1,803 fail - last update
12 months ago 25,888 pass, 1,792 fail - last update
12 months ago 25,964 pass, 1,812 fail - last update
12 months ago 25,942 pass, 1,814 fail - Status changed to Needs review
12 months ago 5:37am 28 December 2023 - π³πΏNew Zealand quietone
Nice to see a reduction in the 'includes'!
I'm triaging RTBC issues β . I read the IS, the comments, the change record and the MR. I didn't see any unanswered questions.
When setting an issue to RTBC the comment should explain what one did to determine the issue was ready for commit to core. For example, did you see something you liked or disliked, what core gates did you check, etc.
I looked at the comments raised by alexpott in the MR and see that they have been marked 'resolved' by the person who made the changes. I do not see any comment from another person that those changes have been reviewed. Therefor, I am setting this back to NR.
I made minor changes to the change record.
- Status changed to Needs work
12 months ago 3:42pm 28 December 2023 - πΊπΈUnited States smustgrave
Some small changes. Rebased as the current MR didn't have the pipeline code yet.
- Status changed to Needs review
12 months ago 1:27pm 4 January 2024 - πΊπ¦Ukraine voleger Ukraine, Rivne
Rebased, addressed review comments. Thanks
- Status changed to Needs work
12 months ago 2:52pm 4 January 2024 - πΊπΈUnited States smustgrave
Seems to have code failure, have not re-reviewed yet.
- Status changed to Needs review
12 months ago 11:35am 5 January 2024 - πΊπ¦Ukraine voleger Ukraine, Rivne
New tests require strict_types declaration. Fixed
- Status changed to Needs work
12 months ago 2:48pm 5 January 2024 - Status changed to Needs review
11 months ago 9:28pm 11 January 2024 - πΊπ¦Ukraine voleger Ukraine, Rivne
Fixed issue with parameter initialization. Ready for the review.
- πΊπΈUnited States smustgrave
Changes look good to me, and feedback addressed.
+1 RTBC but per new approach for #needs-review-queue-initiative going to leave in NR for a few days for additional eyes.
- Status changed to RTBC
11 months ago 5:59pm 23 January 2024 - πΊπΈUnited States smustgrave
Going to go ahead and mark it, been a few days.
- π³πΏNew Zealand quietone
Checking the RTBC queue.
Ah, this is the issue where I commented about the same person making changes in response to comments in MR and them setting those comments to resolved. At the time I didn't realize there are limitations on who can resolve comments.
There have been some changes to the MR but mostly just keeping it up to date.
Leaving at RTBC.
- Status changed to Needs work
10 months ago 5:36pm 27 February 2024 The Needs Review Queue Bot β tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- π¬π§United Kingdom alexpott πͺπΊπ
This will need to make changes due to π Transaction autocommit during shutdown relies on unreliable object destruction order (xdebug 3.3+ enabled) Needs review as that ended up adding a shutdown function.