The file setter functions do not return $this, and do not chain. This is inconsistent with many other objects.
Make the file setter functions chain, and use it in a few uncontroversial places to prove/test that they work.
Apply setter in more places, where it makes sense, and as that code is changed.
None
The File setter functions will return $this where they previously returned nothing. This is backwards compatible.
None
The File setter functions setFilename(), setFileUri(), setMimetype(), setSize(), setPermanent(), and setTemporary() now return $this and can be used in chained operations.
Needs work
10.1 ✨
A change record needs to be drafted before an issue is committed. Note: Change records used to be called change notifications.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
If we are going to make the change should make it for setSize() also. If there is no test then we should add to one.
Taking for a change record for these changes.