The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
liam morland → made their first commit to this issue’s fork.
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
If the value is NULL, the automatic message will result in this error:
Argument #2 ($message) must be of type string, Drupal\Component\Render\FormattableMarkup
- Merge request !9344Resolve #3043127 "Filefieldtestbaseassertfileentrynotexists not properly" → (Open) created by Liam Morland
- Status changed to Needs review
3 months ago 1:01am 28 August 2024 - Status changed to Needs work
3 months ago 1:47pm 29 August 2024 - 🇺🇸United States smustgrave
Can issue summary be updated to use standard template.
Pretty sure javascript is a random failure.
- Status changed to Needs review
3 months ago 1:52pm 29 August 2024 - 🇺🇸United States smustgrave
Shouldn't the default be '' and don't need to typecast?
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Other ones have NULL as the default. The cast is needed anyway because of the error I mentioned in #16.
- Status changed to RTBC
2 months ago 6:25pm 10 September 2024 - 🇺🇸United States smustgrave
Gotcha,
Change seems small then so don't mind marking.