- last update
about 1 year ago 777 pass, 4 fail - last update
about 1 year ago 790 pass - last update
about 1 year ago 791 pass - 🇮🇱Israel jsacksick
Main thing I'm worried about here is duplicating a product with thousands of variations... Even though that concern is also valid for the Product::postSave() logic as we loop over all variations there... This potentially has to be improved btw...
Main thing I'm worried about here is duplicating a product with thousands of variations
This probably is a more general issue, as you mentioned, and maybe it's best to be tackled on a separate issue.
This potentially has to be improved btw
+1
- 🇺🇸United States rhovland Oregon
rhovland → changed the visibility of the branch 3042258-allow-products-to to hidden.
- 🇺🇸United States rhovland Oregon
rhovland → changed the visibility of the branch 3042258-allow-products-to to active.
- 🇺🇸United States rhovland Oregon
One bug we noticed today: The created time of the old product gets duplicated. The creation time should be set to when the duplicate is created.
- Status changed to Needs work
6 months ago 2:25pm 19 August 2024 - 🇺🇸United States rhovland Oregon
rhovland → changed the visibility of the branch 3.0.x to hidden.
- Merge request !352#3042258 bojanz, abx, matthiasm11, igorbarato, s.messaris, walkingdexter, rhovland: Product duplication → (Open) created by rhovland
- 🇺🇸United States rhovland Oregon
Created a new branch for 3.0.x. Attempted to address the creation time issue.
- Status changed to Needs review
about 1 month ago 10:30am 30 December 2024 - 🇳🇱Netherlands flink den haag
I am uncertain this is within the scope of this issue, but i use this module in combination with the paragraphs module. It seems currently that if you have a product with a paragraph field and a paragraph and then clone this product. The exact same paragraph is copied to the cloned product. Resulting in a situation where if you change anything in one product the clone changes too because its the exact same paragraph instead of a new paragraph with the copied information. The quick node clone module does have support for this so maybe this is something that can be copied. Their solution is to loop through all fields and for all paragraph reference fields to then call entity::createDuplicate and then bind this to the field.
I am uncertain this is within the scope of this issue, but i use this module in combination with the paragraphs module. It seems currently that if you have a product with a paragraph field and a paragraph and then clone this product. The exact same paragraph is copied to the cloned product. Resulting in a situation where if you change anything in one product the clone changes too because its the exact same paragraph instead of a new paragraph with the copied information. The quick node clone module does have support for this so maybe this is something that can be copied. Their solution is to loop through all fields and for all paragraph reference fields to then call entity::createDuplicate and then bind this to the field.