- πΊπΈUnited States jcmartinez Raleigh, NC, USA
Tested patch #28 on a site.
The full path doesn't show on a views.
To reproduce:
- Add a display to a media type that contains an image media field. I called mine "Full URL"
- Set the format of the field "URL to Image".
- Click the cogwheel and check the "Use absolute link". Select one image style and hit "Update" and "Save"
- Create a view for the content type that uses this media.
- Add the media field.
- Set Formatter = Rendered entity
- Set View mode = the same you create. In my case "Full URL"
The result is that the field still shows a relative path.
- Status changed to Needs review
over 1 year ago 12:49pm 12 July 2023 - last update
over 1 year ago 29,811 pass - π©πͺGermany mrshowerman Munich
The new field was missing in the schema. The new checkbox is now below the image style selection.
I brought back the tests (see #30) and added a test for the new option.Didn't look into #31 yet. I also agree with #30.2 but I guess that should be handled in another issue.
- Status changed to Needs work
over 1 year ago 3:30pm 12 July 2023 - πΊπΈUnited States smustgrave
So with the new schema it will need an upgrade path for existing sites.
- Status changed to Needs review
over 1 year ago 4:34pm 12 July 2023 - last update
over 1 year ago 29,811 pass - Status changed to Needs work
over 1 year ago 2:51pm 17 July 2023 - πΊπΈUnited States smustgrave
Tested the post_update hook and ran without issues
On a standard profile install reused the Article content type and changed Image field to be URL to image
Saw new setting and confirmed it worked as expected.Will need a change record for the new setting. Nice to have before/after examples in it too.
Thanks!
- Status changed to Needs review
about 1 year ago 3:36am 15 December 2023 - πΊπΈUnited States angrytoast Princeton, NJ
This is exactly the change we needed for exposing image field data to external API consumers. Thanks to all who have contributed!
I took a first stab at a change record using a REST json output as the example. Hopefully that is sufficient and helps this one get merged.
- Status changed to RTBC
about 1 year ago 4:41pm 15 December 2023 - πΊπΈUnited States smustgrave
Believe the CR should be good.
Cleaning up patches for clarity.
Reverified that the post_update hook runs without issue.
Verified that the new setting is appearing.Test coverage follows the existing pattern for testing image formatters so seems good.
- last update
about 1 year ago 30,764 pass - last update
about 1 year ago 30,766 pass - πΊπΈUnited States angrytoast Princeton, NJ
Just came across https://www.drupal.org/project/drupal/issues/2811043 β¨ File formatter render absolute url to file Needs work (File formatter render absolute url to file) which looks like a more complete solution that includes both file + image absolute link options, tests, and cache context considerations.
We should focus on getting that issue merged instead as it is more complete?
- Status changed to Needs review
about 1 year ago 1:22am 18 December 2023 - Status changed to Closed: duplicate
about 1 year ago 7:36pm 19 December 2023 - πΊπΈUnited States smustgrave
More I look at it I agree this is probably a duplicate, going to close this one out.
- π²π©Moldova ion.eftodii
ion.eftodii β changed the visibility of the branch 9.5.x to active.