🇺🇸United States @jcmartinez

While figuring out why I couldn't run `yarn install,` I deleted the file yarn.lock.

Later, after downgrading to Node ver. 14, I could run `yarn install`, but I couldn't get `gulp watch` to complete.

By restoring the original yarn.lock file, I was able to get `gulp watch` working.

Please add the following text to the description of this theme:

Before you can run `yarn install`, ensure your Node version is not newer than 14. The yarn.lock file provided is required to install the proper version of the different Node modules.

jcmartinez → created an issue.

This is a very important request.

Like many developers, I use Lando. Lando will install the latest version of Node.

It took me some time until I found this page to figure out why my subtheme wasn't building.

Please update the documentation or the theme to be compiled using the latest Node version.

Note that every time you patch a module or a theme, the entire content is rewritten by composer. Therefore, after patching, you have to recompile the base theme.

Depending on how your CSS is committed into the repository, it may be possible that the new JS and CSS code generated during the compilation will not be added to the repository. It is up to you how you bring the new JS and CSS code generated inside the base theme into your repository and, ultimately, into your live website. If you don't bring this code to your live website, you'll see the menu working locally while broken on production.

I have created a pull request with a fix.

In the meantime, you can use the commit as a patch with composer by adding the following line to the patches section of your composer.json.

            "droptica/droopler": {
                "Remove JQuery.Once": "https://git.drupalcode.org/project/droopler/-/merge_requests/5.diff"
            }

Then apply the patch:

composer update droptica/droopler

After this, it may be useful to recompile your base theme:

cd web/profiles/contrib/droopler/themes/custom/droopler_theme
npm install -g npm
npm install gulp
gulp compile
drush cr

Same here.

This seems to be related to " Remove jQuery dependency from the once feature → ".

A patch would be great.

jcmartinez → created an issue.

This patch is a remake of my previous patch, to be used after applying two other patches that will bring this module to compatibility with Drupal 10.

Add the following three patches to the patches section of your composer.json file to solve the current issue and to add compatibility to Drupal 10:

        "patches": {
            "drupal/commerce_stock_notifications": {
                "Drupal 10 compatibility": "https://git.drupalcode.org/project/commerce_stock_notifications/-/merge_requests/11.diff",
                "Drupal 10 compatibility Continued": "https://git.drupalcode.org/project/commerce_stock_notifications/-/merge_requests/14.diff",
                "Allow anonymous create notifications": "https://www.drupal.org/files/issues/2023-11-11/3215770-D10-anonymous-notifications.patch"
            }
        }

When the patches that add compatibility to this module are merged, we should be able to use this patch alone to solve the current issue under Drupal 10.

Code maintainers.

The MR14 adds patch #2 contributed by jorisclaes.

If you can accept the MR11 and then the MR14, we should have a version of this module compatible with D10.

Thanks!

jcmartinez → made their first commit to this issue’s fork.

If you work inside Lando or another similar environment, your localhost may have a different name.

In my case, using Lando, this is how I make it work:

// To use Symfony Mailer with Mailhog locally.
$config['symfony_mailer.mailer_transport.sendmail']['configuration']['query']['command'] = ini_get('sendmail_path') . ' -t';
$config['symfony_mailer.mailer_transport.sendmail']['plugin'] = 'smtp';
$config['symfony_mailer.mailer_transport.sendmail']['configuration']['user']='';
$config['symfony_mailer.mailer_transport.sendmail']['configuration']['pass']='';
$config['symfony_mailer.mailer_transport.sendmail']['configuration']['host']='mailhog';
$config['symfony_mailer.mailer_transport.sendmail']['configuration']['port']='1025';

After applying the patch #9, I got a WSOD with the following error message:

The website encountered an unexpected error. Please try again later.
TypeError: Drupal\commerce_google_tag_manager\EventSubscriber\CommerceEventsSubscriber::trackCartView(): Argument #1 ($event) must be of type Drupal\commerce_google_tag_manager\EventSubscriber\GetResponseEvent, Symfony\Component\HttpKernel\Event\RequestEvent given in Drupal\commerce_google_tag_manager\EventSubscriber\CommerceEventsSubscriber->trackCartView() (line 100 of modules/contrib/commerce_google_tag_manager/src/EventSubscriber/CommerceEventsSubscriber.php).
Drupal\commerce_google_tag_manager\EventSubscriber\CommerceEventsSubscriber->trackCartView(Object, 'kernel.request', Object)
call_user_func(Array, Object, 'kernel.request', Object) (Line: 142)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch(Object, 'kernel.request') (Line: 145)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 81)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 718)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

jcmartinez → created an issue.

@superman369 - Done!

You're a co-maintainer now.

Hi, I don't have the bandwidth to maintain this module any longer.

If you have the capacity, feel free to take charge.

jcmartinez → created an issue.

jcmartinez → created an issue.

Solved with fix added to the related ticket.

I just created an Issue Fork with a fix that looks into permissions to allow (or not) anonymous users to create notifications. Off course, this will depend on the permission to be granted by you to the anonymous role.

It works for me on the Dev version of this module.

You can use composer to apply a patch from the plain diff link under the Issue Fork.

Remeber that if you allow anonymous users to subscribe, then you will be in charge of unsubscribing them because they can't do it by themselves.

jcmartinez → created an issue.

This module probably worked for a very specific use case, but it isn't useful for a general ecommerce site, unless this problem is solved.

It was very close to what I needed.

jcmartinez → created an issue.

jcmartinez → created an issue.

I was trying to upgrade a site to Drupal 10 and wanted to use the latest:

composer require 'drupal/group:^3.0@RC'
composer require 'drupal/group:^2.0@RC'

I found that this patch can't be applied to neither of these versions. I don't know if the issue is still present in 3.0@RC'
and 2.0@RC'.

This shouldn't be a blocker for upgrading to D10 because the version 8.x-1.5 Stable shows that Works with Drupal: ^9.3 || ^10

I thought that I should note this here.

It may be possible that this module works well with the patch, but I can't tell because the current README file and the instructions located at https://www.drupal.org/docs/8/modules/commerce-google-tag-manager/setup-... → look more specific to the older version of Google Analytics (GA).

Can anyone document briefly how to use this with GA4 and GTA?

Thanks for the good work!

This issue was introduced by a patch on https://www.drupal.org/project/drupal/issues/2950758 ✨ Empty table cells never hidden if twig debug is true Needs work

I have cretaed a fix for the other issue and I have filed a merge request there.

I just made a small commit that solves for me the issue mentioned in #28.

I also made a merge request.

You can download the patch as a diff directly from my commit. I'm also attaching a patch file here.

jcmartinez → made their first commit to this issue’s fork.

jcmartinez → created an issue.

Tested patch #28 on a site.

The full path doesn't show on a views.

To reproduce:

• Add a display to a media type that contains an image media field. I called mine "Full URL"
• Set the format of the field "URL to Image".
• Click the cogwheel and check the "Use absolute link". Select one image style and hit "Update" and "Save"
• Create a view for the content type that uses this media.
• Add the media field.
• Set Formatter = Rendered entity
• Set View mode = the same you create. In my case "Full URL"

The result is that the field still shows a relative path.