Drupal 10 compatibility

While testing the Drupal 10 fork i ran into a additional issue

Error: Call to a member function getPreferredLangcode() on bool in Drupal\commerce_stock_notifications\Plugin\QueueWorker\CommerceStockNotifyQueue->processItem() (line 114 of modules/contrib/commerce_stock_notifications/src/Plugin/QueueWorker/CommerceStockNotifyQueue.php).

I added a seperate patch for this

changed priority to critical, now that Drupal 9 is reaching EOL next month. there's not too much to do here.

I know, we all spend our spare times for maintaining our Drupal modules, but please take these few minutes and make this module D10 compatible

Code maintainers.

The MR14 adds patch #2 contributed by jorisclaes.

If you can accept the MR11 and then the MR14, we should have a version of this module compatible with D10.

Thanks!

poker10 → closed merge request !12

Thanks for working on this. I think we should focus on MR 11 here.

MR 14 will be solved in ✨ anonymous cannot create notifications although /permissions allow it? Active , so let's not mix this up.

Added a few comments to the MR, otherwise I think this looks good.

Once we fix all outstanding issues, I will roll out a new D10 compatible release (alpha or beta).

Would be good get this merged, I am happy to help by applying the suggested changes if that's all that's required?

@ChrisScrumping yes, it would be great if you can update the MR and prepare it for review. I can take a look then a finish it / commit.

I would say we can keep old core versions and old php versions in case it does not do any harm (maybe it will be less disrupting for sites).

Thanks!

Should be okay now hopefully?

Committed and pushed. Thanks all!

Thanks poker10 great stuff!

Automatically closed - issue fixed for 2 weeks with no activity.