Deprecate drupal_attach_tabledrag(). Move its logic in Table form element

Created on 24 February 2019, almost 6 years ago

Updated 3 May 2023, over 1 year ago

Part of effort to deprecate procedural code in:

Move drupal_attach_tabledrag() functionality to \Drupal\Core\Render\Element\Table form element class as a public static method.
Deprecate drupal_attach_tabledrag()

review/commit

None.

New public static method on \Drupal\Core\Render\Element\Table::attachTabledrag() form element.
drupal_attach_tabledrag() is deprecated.
internal element selector changed to use data-drupal-tabledrag attribute instead of HTML ID (used only internally)

None.

N/A.

📌 Task

Status

Needs review

Version

10.1 ✨

Component

Form →

Last updated 3 minutes ago

Created by

🇷🇴Romania claudiu.cristea Arad 🇷🇴

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
29,219 pass, 51 fail
Comment over 1 year ago →
🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia
Came across this issue from #3015538: [META] Deprecate contents of common.inc → and looks like it needed a rebase on 10.1.x. However, rather than opening another MR, I thought a patch would be quicker and easier.

Looks like tabledrag.js was renamed and had a bit of work done to it, so I've just kept it as is. Not sure whether this is correct or not.
Comment over 1 year ago →
System Message
The last submitted patch, 72: 3035343-tabledrag-72.patch, failed testing. View results →

Production build 0.71.5 2024