Book module constraint validation relies on the presence of a book outline form

Created on 22 February 2019, almost 6 years ago

Updated 4 September 2024, 4 months ago

Currently the book module constraint validation relies upon the form being present on all node edit forms, the issue only occurs in the event of the validation being fired when a page is saved to a draft state.

In this scenario the validation checks the content against the original version (with the default pid of -1), which is the default of the form, but not of the linkDefaults.

So there are two action to fix this problem, 1) change the getLinkDefaults so the pid is by default -1 (as it will be from the form anyway), or 2) change the validator so if the 'original' is empty, then it checks against the presence of -1 (where a form was present) or 0 if the page had no form.

🐛 Bug report

Status

Postponed: needs info

Version

2.0

Component

Book →

Last updated 11 days ago

Maintained by
🇺🇸United States @pwolanin

Created by

🇬🇧United Kingdom andy_w

Live updates comments and jobs are added and updated live.

Needs issue summary update
Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇳🇿New Zealand quietone
This extension is being deprecated, see 🌱 [Meta] Tasks to deprecate Book module Active . It will be removed from core and moved to a contrib project, 📌 [11.x] [Meta] Tasks to remove Book Active .

This is now Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project → and the Extensions approved for removal → policies.

This issue may be re-opened if it can be considered critical → , If unsure, re-open the issue and ask in a comment.
Status changed to Needs work 9 months ago5:30pm 26 April 2024
Comment 9 months ago →
🇺🇸United States smustgrave
Moving to contrib.
Status changed to Postponed: needs info 4 months ago3:54am 4 September 2024
Comment 4 months ago →
🇺🇸United States smustgrave
Still needs an issue summary update or risk closing out.
Comment 4 months ago →
🇺🇸United States smustgrave

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024