- πΊπΈUnited States smustgrave
move this logic either to DateHelper.
This doesn't seem to be in the MR
Left a small nit picky thing in the MR too.
- Status changed to Needs review
almost 2 years ago 11:30pm 19 February 2023 - π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
Rebased on 10.1.x
- Status changed to Needs work
almost 2 years ago 12:54am 20 February 2023 - πΊπΈUnited States smustgrave
Can the proposed solution be updated? Talks about moving to DateHelper but I don't see that?
- Status changed to Needs review
almost 2 years ago 2:46am 20 February 2023 - π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
Updated IS to refer to
Drupal\Core\Datetime\TimeZoneFormHelper::getOptionsList
- Status changed to RTBC
almost 2 years ago 3:44pm 20 February 2023 - πΊπΈUnited States smustgrave
Thank you with sticking with me on this one. Everything looks good to me.
- π¬π§United Kingdom catch
Committed/pushed to 10.1.x, thanks! I'll open the follow-up and link it from here.
- Status changed to Fixed
almost 2 years ago 3:31pm 22 February 2023 - π¬π§United Kingdom catch
Here's the follow-up π Simplify TimeZoneFormHelper Fixed .
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
7 months ago 5:55pm 4 June 2024 - π¨π¦Canada liquidcms
How is this list overridden?
With the old system_time_zones() function i hacked in a patch to add an alter (which i could then use to alter the list). I assumed if this was being redone the ability to alter the list would be included; but i don't see it here. Am i correct that this class can not be overridden?
- π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
@liquidcms I suggest you create a new issue to add this feature.