Coding standard

FILE: /var/www/html/tolearn/modules/git/affiliates_connect/tests/src/Functional/ProductEntityFormTest.php --------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------- 53 | WARNING | Line exceeds 80 characters; contains 84 characters --------------------------------------------------------------------------------------------------------- FILE: /var/www/html/tolearn/modules/git/affiliates_connect/src/Entity/AffiliatesProductInterface.php ---------------------------------------------------------------------------------------------------- FOUND 10 ERRORS AND 2 WARNINGS AFFECTING 8 LINES ---------------------------------------------------------------------------------------------------- 17 | WARNING | [x] There must be no blank line following an inline comment 71 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters 76 | ERROR | [x] Expected 1 blank line after function; 2 found 115 | ERROR | [x] Expected 1 blank line after function; 2 found 325 | ERROR | [x] Expected 1 blank line after function; 2 found 484 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 2 spaces 484 | ERROR | [ ] Parameter comment must start with a capital letter 484 | ERROR | [x] Parameter comment must end with a full stop 485 | ERROR | [x] Data types in @param tags need to be fully namespaced 486 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 2 spaces 486 | ERROR | [ ] Parameter comment must start with a capital letter 486 | ERROR | [x] Parameter comment must end with a full stop ---------------------------------------------------------------------------------------------------- FILE: /var/www/html/tolearn/modules/git/affiliates_connect/src/AffiliatesNetworkBase.php ---------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ---------------------------------------------------------------------------------------- 30 | ERROR | Parameter $logger_factory is not described in comment 75 | WARNING | Empty return statement not required here ---------------------------------------------------------------------------------------- FILE: /var/www/html/tolearn/modules/git/affiliates_connect/src/Controller/AffiliatesConnectController.php --------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------- 86 | ERROR | Type hint "\Drupal\affiliates_connect\AffiliatesNetworkManager" missing for $network --------------------------------------------------------------------------------------------------------- FILE: /var/www/html/tolearn/modules/git/affiliates_connect/modules/affiliates_connect_amazon/src/Form/AmazonItemSearchForm.php ------------------------------------------------------------------------------------------------------------------------------ FOUND 8 ERRORS AND 1 WARNING AFFECTING 9 LINES ------------------------------------------------------------------------------------------------------------------------------ 50 | ERROR | Parameter $temp_store_factory is not described in comment 187 | WARNING | Possible useless method overriding detected 241 | ERROR | Description for the @return value must be on the next line 256 | ERROR | Description for the @return value must be on the next line 284 | ERROR | Description for the @return value is missing 299 | ERROR | Type hint "array" missing for $element 312 | ERROR | Missing parameter comment 314 | ERROR | Description for the @return value is missing 316 | ERROR | Type hint "Drupalaffiliates_connect_amazonAmazonItems" missing for $product_data ------------------------------------------------------------------------------------------------------------------------------ FILE: /var/www/html/tolearn/modules/git/affiliates_connect/modules/affiliates_connect_amazon/src/Form/AffiliatesAmazonSettingsForm.php -------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------- 210 | ERROR | Doc comment is empty --------------------------------------------------------------------------------------------------------------------------------------

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment about 1 year ago →
🇷🇺Russia zniki.ru
zniki.ru → made their first commit to this issue’s fork.
Merge request !35Resolve #3013942 "Coding standard" → (Closed) created by zniki.ru
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
last update about 1 year ago
32 pass, 2 fail
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
last update about 1 year ago
32 pass, 2 fail
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
last update about 1 year ago
32 pass, 2 fail
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
last update about 1 year ago
32 pass, 2 fail
Status changed to Needs review about 1 year ago7:45pm 7 December 2023
Comment about 1 year ago →
🇷🇺Russia zniki.ru
Converted this issue to MR, using patch #17.
MR is ready for review, not sure if css files needs to be fixed in this issue.
Comment about 1 year ago →
🇷🇺Russia zniki.ru
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
last update about 1 year ago
39 pass
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
last update about 1 year ago
39 pass
Comment 9 months ago →
🇮🇳India dev16.addweb
Attached patch to resolve phpcs issues.
Status changed to RTBC 8 months ago7:31am 6 May 2024

Comment 8 months ago →

🇵🇭Philippines paraderojether

I reviewed patch 23, applied against Diff 8.x-1.x-dev, and confirmed it fixes the issues reported by phpcs.

jetherparadero@PrometSources-MacBook-Pro-3 diff % curl https://www.drupal.org/files/issues/2024-04-29/3013942-coding-standard-23.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 19618  100 19618    0     0  55959      0 --:--:-- --:--:-- --:--:-- 57029
patching file README.md
patching file 'css/diff.double-column.css'
patching file 'css/diff.single-column.css'
patching file diff.links.menu.yml
patching file diff.module
patching file diff.services.yml
patching file 'src/DiffEntityParser.php'
patching file 'src/DiffLayoutBase.php'
patching file 'src/Form/GeneralSettingsForm.php'
patching file 'src/Form/RevisionOverviewForm.php'
patching file 'src/Plugin/diff/Field/EntityReferenceFieldBuilder.php'
patching file 'src/Plugin/views/field/DiffFrom.php'
patching file 'src/Plugin/views/field/DiffTo.php'
patching file 'tests/modules/diff_test/diff_test.module'
patching file 'tests/src/Functional/DiffPluginEntityTest.php'
patching file 'tests/src/Functional/DiffPluginTest.php'
patching file 'tests/src/Functional/DiffRevisionTest.php'
jetherparadero@PrometSources-MacBook-Pro-3 diff % cd ..
jetherparadero@PrometSources-MacBook-Pro-3 contrib % phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig diff
jetherparadero@PrometSources-MacBook-Pro-3 contrib %

Thank you.

Status changed to Needs work 8 months ago12:33am 20 May 2024
Comment 8 months ago →
🇦🇺Australia acbramley
Please update to use an MR.
Assigned to atul_ghate
Comment 8 months ago →
🇮🇳India atul_ghate
I will provide the MR.
Issue was unassigned.
Status changed to Needs review 8 months ago11:33am 20 May 2024
Comment 8 months ago →
🇮🇳India atul_ghate
First commit to issue fork.
Merge request !70Issue#3013942: Phpcs fixes. → (Closed) created by ankitv18
Pipeline finished with Failed
8 months ago
Total: 367s
#177328
Pipeline finished with Failed
8 months ago
Total: 224s
#177335
Pipeline finished with Failed
8 months ago
Total: 372s
#177341
Status changed to Needs work 8 months ago11:20pm 20 May 2024
Comment 8 months ago →
🇦🇺Australia acbramley
There are no PHPCS failures on HEAD https://git.drupalcode.org/project/diff/-/pipelines/176683

These changes are causing many failures in the MR.

The only things failing in gitlab CI are eslint and stylelint now.
Status changed to Closed: outdated 8 months ago11:36pm 2 June 2024
Comment 8 months ago →
🇦🇺Australia acbramley
Comment 29 days ago →
System Message
heddn → closed merge request !70
Comment 29 days ago →
System Message
heddn → closed merge request !35

Merge Requests

!35Coding standard
Closed

!70Coding standard
Closed

Comments & Activities

Coding standard

Merge Requests

!35Coding standardClosed

!70Coding standardClosed

Comments & Activities

!35Coding standard
Closed

!70Coding standard
Closed