Allow fields implementing EntityReferenceFieldItemListInterface to clone their referenced entities

This looks like a good solution.

Actually I have doubts about the implementation. This uses a generic service that applies to all entity types, but I doubt that the most common use case for customising this is to want to customise it for all entity types.

I'd imagine it's much more common to customise it for a specific entity type based on the specific fields of that entity type. In which case, it would be better if the clone form handler could call out to clone handler so customisation could be done there. A problem though is that fieldIsClonable is a protected method.

Solution:

1. Remove method fieldIsClonable from ContentEntityCloneFormBase.

2. Add an isFieldClonable method to ContentEntityCloneBase and the relevant interface:

  public function isFieldClonable(FieldItemListInterface $field) {
    // For backwards-compatability use a custom fieldIsClonable method if it exists,
    // otherwise use the clonable field service. 
    if (method_exists('fieldIsClonable')) {
      trigger_error(E_USER_DEPRECATED, 'fieldIsclonable' is deprecated, override isFieldClonableInstead');
      return $this->fieldIsClonable($field->getFieldDefinition());
    }
    return $this->entityCloneClonableField->isClonable($field)
  }

3. In ContentEntityCloneFormBase call the clone handler:

+        $entity_clone_handler = $this->entityTypeManager->getHandler($entity->getEntityTypeId(), 'entity_clone');
+        if ($entity_clone_handler->isFieldClonable($field)) {
+          $form['recursive'] = array_merge($form['recursive'], $this->getRecursiveFormElement($field_definition, $field_id, $field, $discovered_entities));

I took @8ballsteve's patch at #27 and made a new version which works with 2.0.0-beta3.

@Rajeshreeputra please check below error as tests are not executing for this MR!46
No syntax errors detected in /var/www/html/modules/contrib/entity_clone/src/EntityClone/Content/ContentEntityCloneBase.php
No syntax errors detected in /var/www/html/modules/contrib/entity_clone/src/EntityCloneClonableField.php
--- Errors ---
PHP Parse error: syntax error, unexpected '*', expecting function (T_FUNCTION) or const (T_CONST) in /var/www/html/modules/contrib/entity_clone/src/EntityClone/Content/ContentEntityCloneFormBase.php on line 62
xargs: php: exited with status 255; aborting

Looks like couple of changes needed:

• Looks like there's a syntax error in MR. See here.
• Use the dependency injection in Class src/EntityCloneClonableField.phphere
• Remove the unused use statement: use Drupal\Core\Entity\ContentEntityStorageInterface from Class src/EntityClone/Content/ContentEntityCloneFormBase.php.
• Developers won't be able to alter the service because the class ContentEntityCloneFormBase needs contractor of class \Drupal\entity_clone\EntityCloneClonableField. We need to tweak it like:
  1. Create a new interface EntityCloneClonableFieldInterface:
     

     namespace Drupal\entity_clone;
     
     use Drupal\Core\Field\FieldDefinitionInterface;
     use Drupal\Core\Field\FieldItemListInterface;
     
     /**
      * The interface for class EntityCloneClonableField.
      */
     interface EntityCloneClonableFieldInterface {
     
       /**
        * Return whether a field can be cloned or not.
        *
        * @param \Drupal\Core\Field\FieldDefinitionInterface $field_definition
        *   The field definition.
        * @param \Drupal\Core\Field\FieldItemListInterface $field
        *   The field.
        *
        * @return bool
        *   True if the entity can be cloned.
        *
        * @throws \Drupal\Component\Plugin\Exception\PluginNotFoundException
        * @throws \Drupal\Component\Plugin\Exception\InvalidPluginDefinitionException
        */
       public function isClonable(FieldDefinitionInterface $field_definition, FieldItemListInterface $field): bool;
     
     }
     

  2. Update the class ContentEntityCloneFormBase from:

     public function __construct(
         EntityTypeManagerInterface $entity_type_manager,
         TranslationManager $translation_manager,
         EntityCloneSettingsManager $entity_clone_settings_manager,
         ConfigFactoryInterface $config_factory,
         EntityCloneClonableField $entity_clone_clonable_field) {
         $this->entityTypeManager = $entity_type_manager;
         $this->translationManager = $translation_manager;
         $this->entityCloneSettingsManager = $entity_clone_settings_manager;
         $this->configFactory = $config_factory;
         $this->entityCloneClonableField = $entity_clone_clonable_field;
       }
     

     To:

     public function __construct(
         EntityTypeManagerInterface $entity_type_manager,
         TranslationManager $translation_manager,
         EntityCloneSettingsManager $entity_clone_settings_manager,
         ConfigFactoryInterface $config_factory,
         EntityCloneClonableFieldInterface $entity_clone_clonable_field) {
         $this->entityTypeManager = $entity_type_manager;
         $this->translationManager = $translation_manager;
         $this->entityCloneSettingsManager = $entity_clone_settings_manager;
         $this->configFactory = $config_factory;
         $this->entityCloneClonableField = $entity_clone_clonable_field;
       }
     

Please review. Updated MR based on #35.

Needs work here, as there are PHP syntax error. The interface can't implement the method. The interface will only define the method and class with implement the method defined in the interface.

Will check separatly for D10.1.x

Reviewed changes and looks good to me.

merged release to follow shortly. Wil release 2.0.0-beta4!

Automatically closed - issue fixed for 2 weeks with no activity.