Use constants to distinguish d6/d7 table names in source plugins

Created on 30 October 2018, about 6 years ago

Updated 3 February 2023, almost 2 years ago

Problem/Motivation

In one of the recent i18n issues we started defining constants for the Drupal 6 and Drupal 7 for source plugins that share the same code for both versions. One example is 'block' for Drupal 7 and 'blocks' for Drupal 6. Let's complete that for all source plugins.

I grepped for all usages of ModuleSchemaVersion in source plugins and selected only those that need to have unique table names for d6 and d7.

These are the source plugins that need to be changed.

block/src/Plugin/migrate/source/Block.php
This can't be done now becuase it would require deprecating a migration which we can't do yet, 📌 Create a way to declare a plugin as deprecated Needs work . See #19 📌 Use constants to distinguish d6/d7 table names in source plugins Closed: won't fix . At the 2021-12-02 Migrate Meeting → , the sentiment was that we should forego refactoring ProfileField because it would not be worth the effort. Other issues should be prioritized.

And if one wants an example look at d6/BoxTranslation and d7/BlockCustomTranslation.

Steps to reproduce

Proposed resolution

Change block/src/Plugin/migrate/source/Block.php

Remaining tasks

Review
Commit

User interface changes

N/A

API changes

\Drupal\block\Plugin\migrate\source\Block deprecated

Data model changes

N/A

Release notes snippet

N/A

📌 Task

Status

Closed: won't fix

Version

10.1 ✨

Component

Migration →

Last updated 3 days ago

Maintained by
🇺🇸United States @benjifisher
@heddn
🇺🇸United States @mikelutz
🇳🇿New Zealand @quietone

Created by

🇳🇿New Zealand quietone

Live updates comments and jobs are added and updated live.

Portland2022

Migrate critical

migrate-d6-d8

migrate-d7-d8

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment almost 2 years ago →
🇺🇸United States benjifisher Boston area
During 📌 [meeting] Migrate Meeting 2023-02-02 2100Z Fixed , I reviewed the patch in #35 and the comments on this issue.

It seems to me that this issue is not worth the effort. It does make sense for a migration to specify the appropriate source plugin instead of making the source plugin figure it out, but with all the work we have to do to deprecate the old behavior and remove it in the next major version, I think we can just leave it as it is.

Thanks to everyone who contributed to this issue, but I am closing it as "won't fix". Let's find other issues that will have more impact!

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024